Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: skeletonlabs/skeleton
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @skeletonlabs/skeleton@1.10.0
Choose a base ref
...
head repository: skeletonlabs/skeleton
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @skeletonlabs/skeleton@1.11.0
Choose a head ref

Commits on Jun 23, 2023

  1. Copy the full SHA
    a042f83 View commit details

Commits on Jul 7, 2023

  1. Merge branch 'dev' of https://github.com/Mahmoud-zino/skeleton into b…

    …ugfix/modal-top-scroll
    Mahmoud-zino committed Jul 7, 2023
    Copy the full SHA
    a977d11 View commit details
  2. Copy the full SHA
    1f00268 View commit details

Commits on Jul 17, 2023

  1. Add passive event listener Modal

    Related to #1755 :
    #1755 (comment)
    ibilux authored Jul 17, 2023
    Copy the full SHA
    444c4a6 View commit details

Commits on Jul 18, 2023

  1. 1
    Copy the full SHA
    16bf199 View commit details
  2. Copy the full SHA
    c2833a3 View commit details
  3. added region props

    Mahmoud-zino committed Jul 18, 2023
    Copy the full SHA
    d50d83e View commit details
  4. Copy the full SHA
    81cce32 View commit details

Commits on Jul 19, 2023

  1. Merge pull request #1772 from jochepr/patch-1

    Added missing '/' to closing '</section>'.
    endigo9740 authored Jul 19, 2023
    Copy the full SHA
    8d6068b View commit details
  2. Merge pull request #1771 from Mahmoud-zino/feat/listbox-region-props

    feat/listbox-region-props
    endigo9740 authored Jul 19, 2023
    Copy the full SHA
    fb4e314 View commit details
  3. Merge pull request #1769 from Mahmoud-zino/bugfix/logo-clouds-typo

    fixed logo-clouds.css typo
    endigo9740 authored Jul 19, 2023
    Copy the full SHA
    b01c908 View commit details
  4. Merge pull request #1756 from ibilux/patch-3

    Add passive event listener Modal
    endigo9740 authored Jul 19, 2023
    Copy the full SHA
    8efad37 View commit details
  5. Merge pull request #1695 from Mahmoud-zino/bugfix/modal-top-scroll

    bugfix: scroll to top of modal, when modal is bigger than view
    endigo9740 authored Jul 19, 2023
    Copy the full SHA
    9d07e49 View commit details

Commits on Jul 22, 2023

  1. corrected translation

    leElvyn authored Jul 22, 2023
    Copy the full SHA
    4a88c1f View commit details
  2. Copy the full SHA
    9568717 View commit details
  3. fix format

    SebasF1349 committed Jul 22, 2023
    Copy the full SHA
    511dbf8 View commit details

Commits on Jul 30, 2023

  1. Copy the full SHA
    118c8af View commit details
  2. fixes a few lint errors

    delight committed Jul 30, 2023
    Copy the full SHA
    77b2510 View commit details

Commits on Jul 31, 2023

  1. Copy the full SHA
    577e3aa View commit details
  2. Merge pull request #1804 from delight/bugfix/skeleton-site

    fixes a few lint errors
    endigo9740 authored Jul 31, 2023
    Copy the full SHA
    be746b1 View commit details
  3. Merge pull request #1803 from Mahmoud-zino/docs/modals-clear-implemen…

    …tation-section
    
    docs/modals-clear-implementation-section
    endigo9740 authored Jul 31, 2023
    Copy the full SHA
    2ecf4fb View commit details
  4. Merge pull request #1791 from SebasF1349/feat/separatorText-new-pagin…

    …ator-prop
    
    feat/add separatorTest prop to paginator
    endigo9740 authored Jul 31, 2023
    Copy the full SHA
    c362bb8 View commit details
  5. Merge pull request #1790 from leElvyn/dev

    minor:corrected translation
    endigo9740 authored Jul 31, 2023
    Copy the full SHA
    fe0a588 View commit details
  6. Changeset audit

    endigo9740 committed Jul 31, 2023
    Copy the full SHA
    f65811e View commit details

Commits on Aug 1, 2023

  1. removed backdrop-blur

    Mahmoud-zino committed Aug 1, 2023
    Copy the full SHA
    0eb1fc1 View commit details
  2. Merge pull request #1807 from Mahmoud-zino/bugfix/remove-blur-from-fo…

    …rm-material
    
    bugfix/remove-blur-from-form-material
    endigo9740 authored Aug 1, 2023
    Copy the full SHA
    8232cd3 View commit details
  3. Merge pull request #1808 from skeletonlabs/dev

    Merge for release 1.11.0
    endigo9740 authored Aug 1, 2023
    1
    Copy the full SHA
    dfc88f0 View commit details
  4. Copy the full SHA
    9a6880a View commit details
  5. Merge pull request #1809 from skeletonlabs/changeset-release/master

    chore(release): version package
    endigo9740 authored Aug 1, 2023
    1
    Copy the full SHA
    bb73227 View commit details
16 changes: 16 additions & 0 deletions packages/skeleton/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
# @skeletonlabs/skeleton

## 1.11.0

### Minor Changes

- chore: Added `separatorText` prop to Paginator to allow localization ([#1791](https://github.com/skeletonlabs/skeleton/pull/1791))

- feat: Added region props in `ListBox` and `ListBoxItem`. ([#1771](https://github.com/skeletonlabs/skeleton/pull/1771))

### Patch Changes

- bugfix: Removed `backdrop-blur` from `variant-form-material` because of high CPU usage on some browsers. ([#1807](https://github.com/skeletonlabs/skeleton/pull/1807))

- bugfix: fixed a minor typo in the Logo Cloud stylesheet ([#1769](https://github.com/skeletonlabs/skeleton/pull/1769))

- bugfix: resolved a scrolling issue when Modals exceeds the visible screen size ([#1695](https://github.com/skeletonlabs/skeleton/pull/1695))

## 1.10.0

### Minor Changes
2 changes: 1 addition & 1 deletion packages/skeleton/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@skeletonlabs/skeleton",
"version": "1.10.0",
"version": "1.11.0",
"description": "A SvelteKit component library.",
"author": "endigo9740 <chris@skeletonlabs.dev>",
"scripts": {
5 changes: 5 additions & 0 deletions packages/skeleton/scripts/tw-settings.json
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@
"class",
"accent",
"active",
"aspectRatio",
"background",
"badge",
"bgBackdrop",
@@ -47,6 +48,7 @@
"gridColumns",
"height",
"hover",
"indent",
"justify",
"meter",
"padding",
@@ -56,6 +58,7 @@
"regionCaption",
"regionCaret",
"regionCell",
"regionChildren",
"regionCone",
"regionContent",
"regionControl",
@@ -79,6 +82,8 @@
"regionPanel",
"regionRowHeadline",
"regionRowMain",
"regionSummary",
"regionSymbol",
"regionTab",
"regionTrail",
"ring",
11 changes: 11 additions & 0 deletions packages/skeleton/src/lib/components/ListBox/ListBox.svelte
Original file line number Diff line number Diff line change
@@ -22,6 +22,14 @@
/** Provide classes to set the listbox item padding styles. */
export let padding: CssClasses = 'px-4 py-2';
// Props (regions)
/** Provide arbitrary classes to style the lead region. */
export let regionLead: CssClasses = '';
/** Provide arbitrary classes to the default region. */
export let regionDefault: CssClasses = '';
/** Provide arbitrary classes to the trail region. */
export let regionTrail: CssClasses = '';
// Props (a11y)
/** Provide the ARIA labelledby value. */
export let labelledby = '';
@@ -32,6 +40,9 @@
setContext('active', active);
setContext('hover', hover);
setContext('padding', padding);
setContext('regionLead', regionLead);
setContext('regionDefault', regionDefault);
setContext('regionTrail', regionTrail);
// Classes
const cBase = '';
17 changes: 14 additions & 3 deletions packages/skeleton/src/lib/components/ListBox/ListBoxItem.svelte
Original file line number Diff line number Diff line change
@@ -24,6 +24,9 @@
export let active: CssClasses = getContext('active');
export let hover: CssClasses = getContext('hover');
export let padding: CssClasses = getContext('padding');
export let regionLead: CssClasses = getContext('regionLead');
export let regionDefault: CssClasses = getContext('regionDefault');
export let regionTrail: CssClasses = getContext('regionTrail');
// Classes
const cBase = 'cursor-pointer -outline-offset-[3px]';
@@ -85,11 +88,19 @@
}
}
// Base Classes
const cRegionLead = '';
const cRegionDefault = 'flex-1';
const cRegionTrail = '';
// Reactive
$: selected = multiple ? group.some((groupVal: unknown) => areDeeplyEqual(value, groupVal)) : areDeeplyEqual(group, value);
$: classesActive = selected ? active : hover;
$: classesBase = `${cBase} ${rounded} ${padding} ${classesActive} ${$$props.class ?? ''}`;
$: classesLabel = `${cLabel}`;
$: classesRegionLead = `${cRegionLead} ${regionLead}`;
$: classesRegionDefault = `${cRegionDefault} ${regionDefault}`;
$: classesRegionTrail = `${cRegionTrail} ${regionTrail}`;
</script>

<label>
@@ -116,11 +127,11 @@
<!-- <slot /> -->
<div class="listbox-label {classesLabel}">
<!-- Slot: Lead -->
{#if $$slots.lead}<div class="listbox-label-lead"><slot name="lead" /></div>{/if}
{#if $$slots.lead}<div class="listbox-label-lead {classesRegionLead}"><slot name="lead" /></div>{/if}
<!-- Slot: Default -->
<div class="listbox-label-content flex-1"><slot /></div>
<div class="listbox-label-content {classesRegionDefault}"><slot /></div>
<!-- Slot: Trail -->
{#if $$slots.trail}<div class="listbox-label-trail"><slot name="trail" /></div>{/if}
{#if $$slots.trail}<div class="listbox-label-trail {classesRegionTrail}"><slot name="trail" /></div>{/if}
</div>
</div>
</label>
Original file line number Diff line number Diff line change
@@ -69,6 +69,8 @@
* @type {string}
*/
export let buttonTextLast: CssClasses = rightAngles;
/** Set the label for the pages separator. */
export let separatorText = 'of';
// Props (A11y)
/** Provide the ARIA label for the First page button. */
@@ -213,7 +215,7 @@
<!-- Details -->
<button type="button" class="{buttonClasses} pointer-events-none !text-sm">
{settings.offset * settings.limit + 1}-{Math.min(settings.offset * settings.limit + settings.limit, settings.size)}&nbsp;<span
class="opacity-50">of {settings.size}</span
class="opacity-50">{separatorText} {settings.size}</span
>
</button>
{:else}
4 changes: 2 additions & 2 deletions packages/skeleton/src/lib/styles/elements/forms.css
Original file line number Diff line number Diff line change
@@ -274,8 +274,8 @@
@apply bg-surface-500/10 dark:bg-surface-500/20;
/* Border */
@apply border-0 border-b-2;
/* Blur */
@apply backdrop-blur;
/* Blur / high CPU usage on some browsers, see https://github.com/skeletonlabs/skeleton/issues/1805 */
/* @apply backdrop-blur; */
}
.variant-form-material[type='file'] {
@apply !py-1.5;
2 changes: 1 addition & 1 deletion packages/skeleton/src/lib/styles/elements/logo-clouds.css
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
/* === Logo Item (Child) === */

.logo-item {
@apply: flex-auto text-center space-x-4 shadow;
@apply flex-auto text-center space-x-4 shadow;
/* Center Contents */
@apply flex justify-center items-center space-x-4;
/* Background */
10 changes: 5 additions & 5 deletions packages/skeleton/src/lib/utilities/Modal/Modal.svelte
Original file line number Diff line number Diff line change
@@ -74,9 +74,9 @@
export let regionFooter: CssClasses = 'flex justify-end space-x-2';
// Base Styles
const cBackdrop = 'fixed top-0 left-0 right-0 bottom-0';
const cTransitionLayer = 'w-full h-full p-4 overflow-y-auto flex justify-center';
const cModal = 'block'; // max-h-full overflow-y-auto overflow-x-hidden
const cBackdrop = 'fixed top-0 left-0 right-0 bottom-0 overflow-y-auto';
const cTransitionLayer = 'w-full h-fit min-h-full p-4 overflow-y-auto flex justify-center';
const cModal = 'block overflow-y-auto'; // max-h-full overflow-y-auto overflow-x-hidden
const cModalImage = 'w-full h-auto';
// Local
@@ -201,8 +201,8 @@
data-testid="modal-backdrop"
on:mousedown={onBackdropInteractionBegin}
on:mouseup={onBackdropInteractionEnd}
on:touchstart
on:touchend
on:touchstart|passive
on:touchend|passive
transition:fade|global={{ duration }}
use:focusTrap={true}
>
Original file line number Diff line number Diff line change
@@ -32,11 +32,6 @@
['<kbd class="kbd">Space</kbd> or <kbd class="kbd">Enter</kbd>', 'Toggles the item panel open or closed.']
]
};
// Local
const loremIpsum =
// cspell:disable-next-line
'Lorem ipsum dolor sit amet consectetur adipisicing elit. Voluptatum eligendi quibusdam odit, temporibus ullam ab enim expedita eum officia ipsum, laboriosam, nobis quasi laborum aspernatur reiciendis dignissimos optio sunt distinctio.';
</script>

<DocsShell {settings}>
Original file line number Diff line number Diff line change
@@ -180,8 +180,8 @@
<CodeBlock
language="html"
code={`
<!-- French: Marcher 1, Marcher 2, ... -->
<Step stepTerm='Marcher'>...</Step>\n
<!-- French: Étape 1, Étape 2, ... -->
<Step stepTerm='Étape'>...</Step>\n
<!-- Spanish: Paso 1, Paso 2, ... -->
<Step stepTerm='Paso'>...</Step>
`}
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@
<div>
<img class="h-auto max-w-full rounded-lg" src="${getImageLink({ id: 'YOErFW8AfkI', w: 128, h: 128 })}" alt="">
</div>
<section>
</section>
`}
/>
</svelte:fragment>
Original file line number Diff line number Diff line change
@@ -78,8 +78,34 @@
</div>
</svelte:fragment>
<svelte:fragment slot="source">
<p>Implement a single instance of the drawer component in your app's root layout above the App Shell (if present).</p>
<CodeBlock language="html" code={`<Drawer />\n\n<!-- <AppShell>...</AppShell> -->`} />
<p>Implement a single instance of the drawer component your app's root layout, above the App Shell (if present).</p>
<CodeBlock
language="html"
code={`
<Drawer>
<p>Hello Skeleton</p>
</Drawer>\n
<!-- <AppShell>...</AppShell> -->
`}
/>
<p>
When you wish to trigger a toast message, import <code class="code">drawerStore</code>, then follow the example below.
</p>
<CodeBlock
language="ts"
code={`
import { drawerStore } from '@skeletonlabs/skeleton';\n
// Open the drawer:
function drawerOpen(): void {
drawerStore.open();
}\n
// Close the drawer:
function drawerOpen(): void {
drawerStore.close();
}
`}
/>
<p>For more examples and configuration options, see the documentation below.</p>
</svelte:fragment>
</DocsPreview>
</svelte:fragment>
@@ -93,6 +119,19 @@
and reusable via a Svelte writable store. Do not reimplement this component for each route page.
</p>
</aside>
<!-- Drawer Component -->
<section class="space-y-4">
<h2 class="h2">Drawer Component</h2>
<p>Implement a single instance of the drawer component in your app's root layout, above the App Shell (if present).</p>
<CodeBlock
language="html"
code={`
<Drawer>(contents)</Drawer>
<!-- <AppShell>...</AppShell> -->
`}
/>
</section>
<section class="space-y-4">
<h2 class="h2">Drawer Store</h2>
<p>Import this anywhere you wish to control the Drawer. Provides an interface to control the drawer component.</p>
Original file line number Diff line number Diff line change
@@ -145,8 +145,34 @@
<button class="btn variant-filled" on:click={modalDemo}>Show Modal</button>
</svelte:fragment>
<svelte:fragment slot="source">
<p>Implement a single instance of the modal component in your app's root layout above the App Shell (if present).</p>
<CodeBlock language="html" code={`<Modal />\n\n<!-- <AppShell>...</AppShell> -->`} />
<p>Implement a single instance of the modal component your app's root layout, above the App Shell (if present).</p>
<CodeBlock
language="html"
code={`
<Modal />\n
<!-- <AppShell>...</AppShell> -->
`}
/>
<p>
When you wish to trigger a modal, import <code class="code">modalStore</code> and
<code class="code">ModalSettings</code>, then follow the example below.
</p>
<CodeBlock
language="ts"
code={`
import { modalStore, type ModalSettings } from '@skeletonlabs/skeleton';\n
// Provide the modal settings
const modal: ModalSettings = {
type: 'alert',
title: 'Example Alert',
body: 'This is an example modal.',
image: 'https://i.imgur.com/WOgTG96.gif',
};\n
// Trigger the modal:
modalStore.trigger(modal);
`}
/>
<p>For more examples and configuration options, see the documentation below.</p>
</svelte:fragment>
</DocsPreview>
</svelte:fragment>
@@ -162,6 +188,18 @@
and reusable via a Svelte writable store. Do not reimplement this component for each route page.
</p>
</aside>
<section class="space-y-4">
<h2 class="h2">Modal Component</h2>
<p>Implement a single instance of the modal component in your app's root layout, above the App Shell (if present).</p>
<CodeBlock
language="html"
code={`
<Modal />
<!-- <AppShell>...</AppShell> -->
`}
/>
</section>
<section class="space-y-4">
<h2 class="h2">Modal Store</h2>
<p>When you wish to trigger a modal, import the <code class="code">modalStore</code>, which acts as the modal queue.</p>
Original file line number Diff line number Diff line change
@@ -136,11 +136,31 @@
</div>
</svelte:fragment>
<svelte:fragment slot="source">
<p>Implement a single instance of the toast component your app's root layout, above the App Shell (if present).</p>
<CodeBlock
language="html"
code={`
<Toast />\n
<!-- <AppShell>...</AppShell> -->
`}
/>
<p>
Import and add a single instance of the Toast component in your app's root layout. Since this is in global scope it will be
possible to reuse this feature throughout your entire application.
When you wish to trigger a toast message, import <code class="code">toastStore</code> and
<code class="code">ToastSettings</code>, then follow the example below.
</p>
<CodeBlock language="html" code={`<Toast />`} />
<CodeBlock
language="ts"
code={`
import { toastStore, type ToastSettings } from '@skeletonlabs/skeleton';\n
// Provide the toast settings
const t: ToastSettings = {
message: 'Lorem ipsum dolor sit amet consectetur adipisicing elit...',
};\n
// Trigger the toast:
toastStore.trigger(t);
`}
/>
<p>For more examples and configuration options, see the documentation below.</p>
</svelte:fragment>
</DocsPreview>
</svelte:fragment>
@@ -154,6 +174,19 @@
and reusable via a Svelte writable store. Do not reimplement this component for each route page.
</p>
</aside>
<!-- Toast Component -->
<section class="space-y-4">
<h2 class="h2">Toast Component</h2>
<p>Implement a single instance of the toast component in your app's root layout, above the App Shell (if present).</p>
<CodeBlock
language="html"
code={`
<Toast />
<!-- <AppShell>...</AppShell> -->
`}
/>
</section>
<!-- Toast Store -->
<section class="space-y-4">
<h2 class="h2">Toast Store</h2>
Loading