Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: skeletonlabs/skeleton
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @skeletonlabs/skeleton@1.11.0
Choose a base ref
...
head repository: skeletonlabs/skeleton
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @skeletonlabs/skeleton@1.12.0
Choose a head ref
  • 14 commits
  • 13 files changed
  • 5 contributors

Commits on Aug 4, 2023

  1. Copy the full SHA
    18bbab9 View commit details

Commits on Aug 5, 2023

  1. Copy the full SHA
    08685fb View commit details
  2. Copy the full SHA
    12b63fe View commit details

Commits on Aug 6, 2023

  1. Copy the full SHA
    964afed View commit details

Commits on Aug 8, 2023

  1. Feat/radio group region label prop (#1836)

    Co-authored-by: endigo9740 <gundamx9740@gmail.com>
    SebasF1349 and endigo9740 authored Aug 8, 2023
    Copy the full SHA
    1c35e15 View commit details

Commits on Aug 9, 2023

  1. Copy the full SHA
    bc9e3e8 View commit details
  2. feat/tree-view-select (#1779)

    Co-authored-by: endigo9740 <gundamx9740@gmail.com>
    Mahmoud-zino and endigo9740 authored Aug 9, 2023
    Copy the full SHA
    fa91c64 View commit details
  3. Copy the full SHA
    c8d3df3 View commit details

Commits on Aug 14, 2023

  1. Revert PR #1779 from dev (#1863)

    AdrianGonz97 authored Aug 14, 2023
    Copy the full SHA
    18021ab View commit details
  2. fixed changeset

    AdrianGonz97 committed Aug 14, 2023
    Copy the full SHA
    de7d711 View commit details
  3. Copy the full SHA
    4938f4f View commit details

Commits on Aug 15, 2023

  1. Merge pull request #1871 from skeletonlabs/dev

    Merge for v1 release
    endigo9740 authored Aug 15, 2023
    1
    Copy the full SHA
    bee7b3f View commit details
  2. Copy the full SHA
    0e3f24e View commit details
  3. Merge pull request #1872 from skeletonlabs/changeset-release/master

    chore(release): version package
    endigo9740 authored Aug 15, 2023
    1
    Copy the full SHA
    4fbf74f View commit details
55 changes: 55 additions & 0 deletions .github/workflows/release-v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: Publish Prerelease Skeleton v2
on:
push:
branches:
- v2

concurrency: ${{ github.workflow }}-${{ github.ref }}

jobs:
release:
name: Build & Publish @latest Release
if: github.repository == 'skeletonlabs/skeleton'
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Use PNPM v8
uses: pnpm/action-setup@v2
with:
version: 8

- name: Use Node v18
uses: actions/setup-node@v3
with:
node-version: 18

# PNPM Store cache setup
- name: Get pnpm store directory
id: pnpm-cache
run: |
echo "pnpm_cache_dir=$(pnpm store path)" >> $GITHUB_OUTPUT
- name: Setup pnpm cache
uses: actions/cache@v3
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
run: pnpm install

- name: Create Release Pull Request or Publish
id: changesets
uses: changesets/action@v1
with:
commit: "chore(release): version package"
title: "chore(release): version package"
publish: pnpm ci:release
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ jobs:
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Update tw-settings.json after publish
if: steps.changesets.outputs.published == 'true'
continue-on-error: true
14 changes: 14 additions & 0 deletions packages/skeleton/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# @skeletonlabs/skeleton

## 1.12.0

### Minor Changes

- feat: Added `regionLabel` prop to Radio Groups ([#1836](https://github.com/skeletonlabs/skeleton/pull/1836))

### Patch Changes

- bugfix: `autocomplete` fixed reactive update when allow and deny lists are empty. ([#1825](https://github.com/skeletonlabs/skeleton/pull/1825))

- bugfix: Fixed `.bg-hover-primary-token` color in dark mode. ([#1824](https://github.com/skeletonlabs/skeleton/pull/1824))

- bugfix: InputChips updates bound value only once. ([#1768](https://github.com/skeletonlabs/skeleton/pull/1768))

## 1.11.0

### Minor Changes
2 changes: 1 addition & 1 deletion packages/skeleton/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@skeletonlabs/skeleton",
"version": "1.11.0",
"version": "1.12.0",
"description": "A SvelteKit component library.",
"author": "endigo9740 <chris@skeletonlabs.dev>",
"scripts": {
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@
// Local
$: listedOptions = options;
function filterByAllowDeny() {
function filterByAllowDeny(allowlist: unknown[], denylist: unknown[]) {
let _options = [...options];
// Allowed Options
if (allowlist.length) {
@@ -102,7 +102,7 @@
}
// State
$: if (allowlist.length || denylist.length) filterByAllowDeny();
$: filterByAllowDeny(allowlist, denylist);
$: optionsFiltered = input ? filterOptions() : listedOptions;
$: sliceLimit = limit !== undefined ? limit : optionsFiltered.length;
// Reactive
Original file line number Diff line number Diff line change
@@ -158,11 +158,6 @@
$: classesInterface = `${cInterface}`;
$: classesChipList = `${cChipList}`;
$: classesInputField = `${cInputField}`;
$: chipValues =
value?.map((val, i) => {
if (chipValues[i]?.val === val) return chipValues[i];
return { id: Math.random(), val: val };
}) || [];
</script>

<div class="input-chip {classesBase}" class:opacity-50={$$restProps.disabled}>
3 changes: 3 additions & 0 deletions packages/skeleton/src/lib/components/Radio/RadioGroup.svelte
Original file line number Diff line number Diff line change
@@ -27,6 +27,8 @@
export let color: CssClasses = '';
/** Provide classes to set the highlighted SVG fill color. */
export let fill: CssClasses = '';
/** Provide classes for the label region. */
export let regionLabel: CssClasses = '';
// Props (a11y)
/** Provide the ARIA labelledby value. */
@@ -39,6 +41,7 @@
setContext('hover', hover);
setContext('color', color);
setContext('fill', fill);
setContext('regionLabel', regionLabel);
// Classes
const cBase = 'p-1';
14 changes: 9 additions & 5 deletions packages/skeleton/src/lib/components/Radio/RadioItem.svelte
Original file line number Diff line number Diff line change
@@ -31,9 +31,11 @@
export let hover: CssClasses = getContext('hover');
export let color: CssClasses = getContext('color');
export let fill: CssClasses = getContext('fill');
export let regionLabel: CssClasses = getContext('regionLabel');
// Classes
const cBase = 'flex-auto text-base text-center cursor-pointer';
const cBase = 'flex-auto';
const cWrapper = 'text-base text-center cursor-pointer';
const cDisabled = 'opacity-50 cursor-not-allowed';
// Local
@@ -47,11 +49,13 @@
}
}
// Reactive
// State
$: checked = value === group;
$: classesActive = checked ? `${active} ${color} ${fill}` : hover;
$: classesDisabled = $$props.disabled ? cDisabled : '';
$: classesBase = `${cBase} ${padding} ${rounded} ${classesActive} ${classesDisabled} ${$$props.class ?? ''}`;
// Reactive
$: classsBase = `${cBase}`;
$: classesWrapper = `${cWrapper} ${padding} ${rounded} ${classesActive} ${classesDisabled} ${$$props.class ?? ''}`;
// RestProps
function prunedRestProps() {
@@ -60,10 +64,10 @@
}
</script>

<label>
<label class="radio-label {classsBase} {regionLabel}">
<!-- A11y attributes are not allowed on <label> -->
<div
class="radio-item {classesBase}"
class="radio-item {classesWrapper}"
data-testid="radio-item"
role="radio"
aria-checked={checked}
2 changes: 1 addition & 1 deletion packages/skeleton/src/lib/tailwind/tokens/backgrounds.cjs
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ module.exports = () => {
// Hover
// Example: .bg-primary-hover-token
classes[`.bg-${n}-hover-token:hover`] = { 'background-color': `rgb(var(--color-${n}-500) / ${hoverAlpha})` };
classes[`.dark .bg-${n}-hover-token:hover`] = { 'background-color': `rgb(var(--color-${n}-200) / ${hoverAlpha})` };
classes[`.dark .bg-${n}-hover-token:hover`] = { 'background-color': `rgb(var(--color-${n}-500) / ${hoverAlpha})` };

// Active
// Example: .bg-primary-active-token
Original file line number Diff line number Diff line change
@@ -103,12 +103,6 @@
</button>
<!-- popup -->
<div class="card p-4 w-60 shadow-xl" data-popup="features">
<a class="btn variant-filled w-full" href="https://store.skeleton.dev" target="_blank">
<!-- <i class="fa-solid fa-cart-shopping" /> -->
<span>Skeleton Store</span>
<span class="badge variant-filled-secondary">New</span>
</a>
<hr class="!my-4" />
<nav class="list-nav">
<ul>
<li>
@@ -129,6 +123,12 @@
<span>Blog</span>
</a>
</li>
<li>
<a href="https://store.skeleton.dev" target="_blank">
<span class="w-6 text-center"><i class="fa-solid fa-shopping-cart" /></span>
<span>Skeleton Store</span>
</a>
</li>
<hr class="!my-4" />
<li>
<a href="/elements/core">
Original file line number Diff line number Diff line change
@@ -131,7 +131,7 @@
<CodeBlock
language="html"
code={`
<AppRailTile bind:group={currentTile} name="tile-1" value={0} title="tile-1>
<AppRailTile bind:group={currentTile} name="tile-1" value={0} title="tile-1">
<svelte:fragment slot="lead">(icon)</svelte:fragment>
<span>Tile 1</span>
</AppRailTile>
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
import DocsShell from '$lib/layouts/DocsShell/DocsShell.svelte';
import { DocsFeature, type DocsShellSettings } from '$lib/layouts/DocsShell/types';
// Components
import { RadioGroup, RadioItem, CodeBlock } from '@skeletonlabs/skeleton';
import { CodeBlock, RadioGroup, RadioItem } from '@skeletonlabs/skeleton';
// Sveld
import sveldRadioGroup from '@skeletonlabs/skeleton/components/Radio/RadioGroup.svelte?raw&sveld';
import sveldRadioItem from '@skeletonlabs/skeleton/components/Radio/RadioItem.svelte?raw&sveld';
@@ -19,7 +19,11 @@
restProps: 'RadioItem input',
components: [
{ label: 'RadioGroup', sveld: sveldRadioGroup },
{ label: 'RadioItem', sveld: sveldRadioItem, overrideProps: ['padding', 'hover', 'accent', 'color', 'fill', 'rounded'] }
{
label: 'RadioItem',
sveld: sveldRadioItem,
overrideProps: ['padding', 'hover', 'accent', 'color', 'fill', 'rounded', 'regionLabel']
}
],
keyboard: [
['<kbd class="kbd">Tab</kbd>', 'Moves focus to the next focusable RadioItem.'],
@@ -40,6 +44,8 @@
<svelte:fragment slot="sandbox">
<DocsPreview>
<svelte:fragment slot="preview">
<!-- Use this to test full width sizing -->
<!-- <RadioGroup class="text-token w-full" display="flex"> -->
<RadioGroup class="text-token">
<RadioItem bind:group={justify} name="justify" value={0}>
<i class="fa-solid fa-align-left" />
17 changes: 12 additions & 5 deletions sites/skeleton.dev/src/routes/+page.svelte
Original file line number Diff line number Diff line change
@@ -20,12 +20,19 @@

<div>
<!-- Promo Banner -->
<div class="variant-filled-secondary p-4 flex justify-between items-center gap-4">
<div class="flex items-center gap-6">
<i class="fa-solid fa-cart-shopping text-xl" />
<p><strong>Skeleton Store</strong> now available! Get premium templates designed for Skeleton.</p>
<div class="variant-filled-warning p-4">
<div class="w-full max-w-7xl mx-auto grid grid-cols-1 md:grid-cols-[1fr_auto] gap-4">
<div class="flex items-center gap-6">
<span class="text-xl">🎉</span>
<p>The Skeleton v2.0 Release Candidate is now available!</p>
</div>
<div class="flex gap-4">
<a class="btn variant-filled" href="https://github.com/skeletonlabs/skeleton/discussions/1845" target="_blank">What's New?</a>
<a class="btn variant-filled" href="https://skeleton-docs-git-v2-skeleton-labs.vercel.app/docs/get-started" target="_blank">
Docs &rarr;
</a>
</div>
</div>
<a class="btn variant-filled" href="https://store.skeleton.dev" target="_blank">Visit Store</a>
</div>

<!-- hero -->