-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tabs vertical #2666
Comments
Tabs have already been completed for v3, did we consider a vertical mode for them @endigo9740 ? |
I hope implementation will be considered |
It is being considered for v3, but poses a number of challenges to get the styling just right, while also keeping it customizable. It's not as simple as swapping from a row to column as you might think. |
It seemed simple to me, reading this link: |
@zfranco55 tabs are not a browser native UI component, which means there's no set standard on how they are designed and built. W3 Schools is simply demonstrating one of many different ways this interface can be constructed. For comparison, you can take a look at how Skeleton implements tabs here: https://github.com/skeletonlabs/skeleton/tree/master/packages/skeleton/src/lib/components/Tab Remember, we're building components, which means some level of abstraction around the HTML/CSS is happening here. Then we're applying our own theme and style prop systems on-top of this. In order to support a vertical layout we would have to:
That last step is the most involved and becomes more troublesome if we wish to support both left and right alignment in the vertical state. So again, I'll echo that it's technically possible, but likely beyond the scope of changes we're willing and able to implement in Skeleton v2. We are, as mentioned, considering this for Skelton v3 - as we're already rebuilding the components to take advantage of Svelte 5 and a number of other foundational changes to Skeleton itself. So we're taking that opportunity to introduce new features and structural changes. If you need an interim solution, I might suggest Listbox, which operates in a similar manner: |
Describe the feature in detail (code, mocks, or screenshots encouraged)
Is possible implement vertical left/right side version of tabs component?
What type of pull request would this be?
Enhancement
Provide relevant links or additional information.
No response
The text was updated successfully, but these errors were encountered: