Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing should.js transformations #116

Open
2 tasks
skovhus opened this issue May 14, 2018 · 2 comments
Open
2 tasks

Implement missing should.js transformations #116

skovhus opened this issue May 14, 2018 · 2 comments

Comments

@skovhus
Copy link
Owner

skovhus commented May 14, 2018

When converting webpack to Jest, jest-codemods failed on converting the should.js construct oneOf.

Let us go over the should.js transformer and see if there are more matchers that I missed.

  • expect(typeof id).to.be.oneOf("number", "string")
  • figure out if there are more matchers that are not supported by jest-codemods
@niieani
Copy link

niieani commented May 14, 2018

I remember there were also quite a few false positives (where changes were made to code that shouldn't have been touched by the codemods).

@skovhus
Copy link
Owner Author

skovhus commented May 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants