Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(refactor): upgrade to esm #182

Closed
wants to merge 13 commits into from
Closed

feat(refactor): upgrade to esm #182

wants to merge 13 commits into from

Conversation

bryanjtc
Copy link
Contributor

@bryanjtc bryanjtc commented Jan 27, 2023 •
edited

BREAKING CHANGE: Drops node 12 support and upgrades node-sass to v8
Fixes: #181

  • Semantic-release requires node 18 to run. This has been updated in travis-ci.yml.
  • Jest now uses swc instead of babel.
  • Added tsup to bundle code. Package is now smaller.
  • Replaced chalk with colorette (Faster alternative). Superseeded by chore: replace chalk with colorette #189
  • Replaced glob with fast-glob (Faster alternative).
  • Replace reserved-words with @frida/reserved-words. (ESM alternative)
  • Only 2 tests are failing for now. Tested locally without jest and without errors. This 2 tests are now skipped.
  • Travis-ci now runs test stage with all supported node versions. Linting only with node 18. Build image is now ubuntu 22.04.
  • Added tsx to run command typed-scss-modules. Tsx has better esm support.
  • All dependencies were updated to their latest release, except esbuild. Esbuild 0.17 has some breaking changes.
  • Upgraded yarn to v3. Superseeded by build(npm): migrate to npm #183

@bryanjtc bryanjtc marked this pull request as ready for review January 27, 2023 20:45
@bryanjtc bryanjtc marked this pull request as draft January 27, 2023 22:48
@bryanjtc bryanjtc marked this pull request as ready for review January 27, 2023 23:12
@bryanjtc
Copy link
Contributor Author

@skovy Can you check this?

@skovy
Copy link
Owner

skovy commented Feb 2, 2023

I'm generally on board with most or all of these changes and appreciate you doing this work and opening this pull request 👍

Is there any way we can break this up into several smaller PRs? this is a lot to review and changes a lot of pieces.

Since there are a lot of changes it could be nice to setup a new branch for alpha versions to build up to a new major release, which is something I could do if you then want to submit smaller changes to it?

@bryanjtc
Copy link
Contributor Author

bryanjtc commented Feb 2, 2023

Sure

@bryanjtc
Copy link
Contributor Author

bryanjtc commented Feb 4, 2023

I will first open pull requests for changes that don't need a major release.

@skovy
Copy link
Owner

skovy commented Mar 14, 2023

Closing based on above conversation.

@skovy skovy closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert package to esm
2 participants
@bryanjtc @skovy