New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Feedback thread on tutorial notebooks #1447
Comments
from #1446, we ought to include sections on tags and estimator lookup in all tutorials; |
@gepitis, did you want to post some feedback on the tutorial notebooks? We've opened this just for you! (well, and also others who may like to provide such feedback, but you triggered the issue) |
Hi all! For example: terms like forecasting horizon, prediction intervals etc. |
Great idea, @shubhamkarande13! There is already a glossary in the sktime docs, but it´s a bit incomplete I was working on a sci reference, but got sidetracked by maintenance efforts. |
Hello!
Regards! |
@fkiraly I would like to contribute by adding relevant terms to the glossary and learn in the process! Please let me know how we can move forward! |
@claudia-hm, thanks for the feedback! I just looked and I feel the tutorials are outdated, and there is a duplication with "user guide". |
@claudia-hm, I've just reviewed the three different places where there are notebooks or user guides... Anyway, I've suggested a plan how this could be improved, nice contribution opportunity: #2127 |
@shubhamkarande13, thanks!
May I suggest a very similar alternative? The tutorials and user guides are a bit of a mess, see #2127, would you like to start moving them to a clean state, we could then increase the level of content over splicing/merging, up to writing the missing tutorials? |
Hi. I am currently working through the forecasting tutorial. Quick observations:
This being said, the first note is also most likely not correct anymore, given that there is a section on multivariate ts.
Best Edit: |
Hello, I read through the Loading data into sktime tutorial, and I have a few suggestions.
Best regards |
Thanks, @hilal-g! |
Can you add a notebook that shows the functionality/use of MultiplexTransformer, OptionalPassThrough, TransformerPipeline, FeatureUnion, YtoX, etc. Something exploring the space of transformation unions / compositions would be extremely helpful. This also might make sense as general functions to add to the library (union all transformations in the library), or some kind of (greedy/genetic?) algorithm to span the combinations space. |
Yes! I was working on it: Help is appreciated (search for "good first issues" 😄 ) - anything that takes pressure off the various other places makes it more likely that we write nice notebooks. Meanwhile, the docstrings should, hopefully, be helpful.
You can already use things like the |
@CadePGCM, good news for you! We are writing a transformers & pipelines tutorial together with @miraep8 and the pywatts team (@benHeid, @kalebphipps, @SMEISEN) in preparation for a potential presentation at pydata. And thanks for the suggestion, this is frequently requested indeed! |
Hello, I am currently working on a forecasting task where I am interested to run tuning of hyperparameters and backtesting simultaneously. I might have overlooked it, but could not find anything similar in the docs or tutorials, so far. Thank you and best regards, B |
Hello! Best |
Thanks for reporting. It's odd that this did not get caught by the tests, afaik they run all notebook cells. We'll look into this. |
Following some of my recent Discord comments on panel data and time-series classification, I've prepared the following file. I'm a novice Python programmer, so it might be a bit flabby, but there are two points that are probably of interest to other novices. |
With so many functions available for time-series classification, it would be good to have some more guidance, say in the introductory text at the top of help pages. Here's one good example of a useful tip, from the page for
" Compare this with something like the page for If we have panel data, we can maybe work out that we need to combine our multivariate data for each instance into a univariate series. So, we can use I'm sure that once people gain more experience, this is easier to work out. But at the start, with so many different approaches (and other issues around reproducibility, see other comments), there's quite a knowledge gap to bridge just getting started. I suspect it might be possible to give other guidelines on which conditions are suitable for certain choices of transformer/classifier? Maybe some choices are better depending on whether you have thousands of data points or just hundreds (and find that some transformers produce NaN that stop the fitting process)? |
@jmwhyte, are you thinking of sth like this https://scikit-learn.org/stable/tutorial/machine_learning_map/index.html just for sktime? |
FYI @marrov - similar to what you have suggested as well |
Something like that sklearn diagram would be a good start, but I am sure there is also benefit in more detail at the function level. |
Hi, |
thanks, useful feedback, @madhuri723. Let's see if we can improve the explanation. |
@fkiraly I can take up this work. |
@madhuri723, thanks! Please go ahead! |
Hi, I have gone over the introductory notebook (00_sktime_intro), and it was very informative! I have come up with a couple of suggestions for the notebook and have included them in this document: https://docs.google.com/document/d/1w4lI7m5kWupSZCipr7N7HRPGbNimKAWCnzcdTvnVni4/edit Thanks, and please let me know what you think! |
@Prakruthi12345, nice! Could you please move these suggestions to a GitHub issue? |
@fkiraly will do, thanks! |
Hi there! The code snippet (of 2.2.4 Time Series Classification - simple evaluation vignette) seems that the import statement for KNeighborsTimeSeriesClassifier (from sktime.classification.distance_based import KNeighborsTimeSeriesClassifier) is duplicated, appearing both in line 1 & line 9. Suggesting to remove the redundant (line 9) for any possible confusion |
thanks! Would you like to make a PR? |
Sure!! I would do a PR |
This issue is for collecting feedback on the tutorial notebooks.
Any feedback is highly appreciated, positive or critical; can be high-level (e.g., too long where, helpful why, confusing how), or concrete, e.g., content that should be added, changed, removed, shortened, structured differently, etc.
The text was updated successfully, but these errors were encountered: