Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] classifiers failing on multiclass scenario due to _get_train_probs #6376

Open
fkiraly opened this issue May 2, 2024 · 1 comment · May be fixed by #6377
Open

[BUG] classifiers failing on multiclass scenario due to _get_train_probs #6376

fkiraly opened this issue May 2, 2024 · 1 comment · May be fixed by #6377
Labels
bug Something isn't working module:classification classification module: time series classification

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 2, 2024 •
edited

The following classifiers fail on a scenario with three classes, see #6374 for the scenario:

  • Arsenal
  • BOSSEnsemble
  • ContractableBOSS
  • DrCIF
  • FreshPRINCE
  • ShapeletTransformClassifier
  • TemporalDictionaryEnsemble
  • TSCGridSearchCV - reason is not the classifier, but folds being too small in the scenario
  • WeightedEnsembleClassifier

A quick solution could be to introduce a capability:multiclass tag, but perhaps the bug is easy to fix.
@fkiraly fkiraly added bug Something isn't working module:classification classification module: time series classification labels May 2, 2024
@fkiraly fkiraly mentioned this issue May 2, 2024
Open
6 tasks
@fkiraly fkiraly changed the title [BUG] classifiers failing on multiclass scenario [BUG] classifiers failing on multiclass scenario due to _get_train_probs May 2, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented May 2, 2024

Update: this is due to the _get_train_probs legacy method which has an undefined contract but which seems to assume a narrow range of data types (e.g., 3D numpy).

@fkiraly fkiraly linked a pull request May 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module:classification classification module: time series classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] fix _get_train_probs in some classifiers to accept any input data type sktime/sktime
1 participant
@fkiraly