You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For every release, two PR's are created: first to disable testing full test suite and second to revert first. Is there any reason to not remove it permanently?
The text was updated successfully, but these errors were encountered:
I consider it a safety mechanism, reducing the risk of error.
It introduces a delay between pressing the green button and the actual release
It runs the full test suite between the green button and the actual release, so will not release if there are genuine (not sporadic) failures.
in the past, I have skipped this due to sporadic failures, or failures we knew were inconsequential. However, in all cases, I've run through the mandatory pre-release test, which I think improved safety and reliability.
Phrased more negatively, if we remove it permanently, I would be apprehensive of irreversible release actions by accident.
Though, instead of manual approval, how about a simple time delay? Given history, I am not sure if it is feasible to insist on reviews at every release, in the sense that these might not materialize and then things get blocked through inaction.
For every release, two PR's are created: first to disable testing full test suite and second to revert first. Is there any reason to not remove it permanently?
The text was updated successfully, but these errors were encountered: