Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] duplicated BaseDeepNetworkPyTorch in forecasting and networks module #6391

Closed
fkiraly opened this issue May 5, 2024 · 0 comments · Fixed by #6398
Closed

[BUG] duplicated BaseDeepNetworkPyTorch in forecasting and networks module #6391

fkiraly opened this issue May 5, 2024 · 0 comments · Fixed by #6398
Labels
bug Something isn't working module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 5, 2024

The BaseDeepNetworkPyTorch seems duplicated, once in the forecasting and once in the networks module.

This should be resolved. I believe both were added by @luca-miniati, is this a merge accident?

The two locations:

  • forecasting.base.adapters._pytorch
  • networks.base

I think the correct location is the forecasting module, as the adapter is spevific to forecasters.

FYI @benHeid, @luca-miniati; FYI @fnhirwa, @geetu040, @julian-fong, @pranavvp16, @Xinyu-Wu-0000 due to related projects.
@fkiraly fkiraly added bug Something isn't working module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting labels May 5, 2024
@luca-miniati luca-miniati mentioned this issue May 7, 2024
Merged
fkiraly pushed a commit that referenced this issue May 20, 2024
@luca-miniati
[BUG] Remove duplicated BaseDeepNetworkPyTorch in networks.base (#…
2387e12 
…6398)

#### Reference Issues/PRs
Fixes #6391

#### What does this implement/fix? Explain your changes.
Remove duplicated class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Remove duplicated BaseDeepNetworkPyTorch in networks.base luca-miniati/sktime
1 participant
@fkiraly