Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove duplicated BaseDeepNetworkPyTorch in networks.base #6398

Merged
merged 3 commits into from May 20, 2024

Conversation

luca-miniati
Copy link
Contributor

Reference Issues/PRs

Fixes #6391

What does this implement/fix? Explain your changes.

Remove duplicated class

@fkiraly fkiraly added module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting enhancement Adding new functionality labels May 7, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented May 7, 2024

So, it wasn't even used?

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge or copy-paste error, I suppose then?

@fkiraly fkiraly merged commit 2387e12 into sktime:main May 20, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] duplicated BaseDeepNetworkPyTorch in forecasting and networks module
2 participants