Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] improve local testing experience, setup.cfg feedback #6407

Open
fkiraly opened this issue May 11, 2024 · 0 comments
Open

[MNT] improve local testing experience, setup.cfg feedback #6407

fkiraly opened this issue May 11, 2024 · 0 comments
Labels
enhancement Adding new functionality maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 11, 2024

Some feedback and potential actions from today's meetup.

Related to setup.cfg, we should consider which parameters we keep in there.

  • --cov and --cov-report parameters are unnecessary for local testing, and they increase test collection time significantly, see [BUG] long test collection time and test timeouts #6344. These could be removed, and included in the makefile or GHA file instead.
  • @yarnabrina mentioned that -n auto, for him, increases test time instead of shortening it. @Xinyu-Wu-0000 also reported long test collection times.
  • the --matrixdesign True flag seems to cause locally collected tests to result in some estimators not being collected. It should probably be switched off in setup.cfg and turned on in the makefile.

Further, possibly unrelated, a change in HolidayFeaturesTransformer was not collected in local tests by TestAllTransformers - only in TestAllEstimators and TestAllObjects.

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests enhancement Adding new functionality labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Development

No branches or pull requests

1 participant