Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codecov fails to run #1427

Open
kgiusti opened this issue Feb 28, 2024 · 3 comments
Open

codecov fails to run #1427

kgiusti opened this issue Feb 28, 2024 · 3 comments
Assignees
@kgiusti
Labels
blocked Cannot resolve due to external factor (see comments)

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Feb 28, 2024

codecov app version 4 changed its API:

codecov/codecov-action#1247

Need to also include git dependency and generate a secret key
@kgiusti kgiusti self-assigned this Feb 28, 2024
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Feb 28, 2024
@kgiusti
Fixes skupperproject#1427: update codecov/codecov-action v4 API
d9547d8 
Closes skupperproject#1427
@kgiusti kgiusti mentioned this issue Feb 28, 2024
Closed
@ganeshmurthy
Copy link
Contributor

Fixed via 12c7c7e

@kgiusti
Copy link
Contributor Author

kgiusti commented Feb 29, 2024

Reopening - this patch is a work-around. We need to migrate to codecov V4 as V3 is no longer supported.

@kgiusti kgiusti reopened this Feb 29, 2024
@kgiusti kgiusti added the blocked Cannot resolve due to external factor (see comments) label Feb 29, 2024
@kgiusti
Copy link
Contributor Author

kgiusti commented Feb 29, 2024

Refer to codecov/codecov-action#1248 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgiusti kgiusti

Labels
blocked Cannot resolve due to external factor (see comments)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1427: update codecov/codecov-action v4 API kgiusti/skupper-router
2 participants
@kgiusti @ganeshmurthy