Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1427: update codecov/codecov-action v4 API #1428

Closed
wants to merge 2 commits into from
Closed

Fixes #1427: update codecov/codecov-action v4 API #1428

wants to merge 2 commits into from

Conversation

kgiusti
Copy link
Contributor

@kgiusti kgiusti commented Feb 28, 2024

Closes #1427

jiridanek
jiridanek approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jiridanek jiridanek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit, i never actually did anything with this updated action yet, so I'm going to trust you to figure usage

@kgiusti
Copy link
Contributor Author

kgiusti commented Feb 28, 2024

Looks like my changes still are not fixing the issue.
I've added my info to this codecov/codecov-action#1248 (comment)

If there's no movement on that issue I'll create a new one.

For now I propose we fall back to v3.

@kgiusti kgiusti marked this pull request as draft February 28, 2024 16:22
@kgiusti kgiusti closed this Apr 11, 2024
@kgiusti kgiusti deleted the ISSUE-1427 branch April 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiridanek jiridanek jiridanek approved these changes

@ganeshmurthy ganeshmurthy Awaiting requested review from ganeshmurthy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

codecov fails to run
2 participants
@kgiusti @jiridanek