Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git precommit with clang-format #660

Closed
jiridanek opened this issue Aug 5, 2022 · 2 comments · Fixed by #663 or #669 · May be fixed by #662
Closed

Add git precommit with clang-format #660

jiridanek opened this issue Aug 5, 2022 · 2 comments · Fixed by #663 or #669 · May be fixed by #662
Assignees
@jiridanek
Labels
task Minor work item - not a bug or feature
Milestone
2.1.0

Comments

@jiridanek
Copy link
Contributor

This follows up to
@jiridanek jiridanek mentioned this issue Aug 5, 2022
Closed
@jiridanek
Copy link
Contributor Author

jiridanek commented Aug 5, 2022 •
edited

There are two possibilities, either write the hook from scratch, or use one of the hook frameworks

@jiridanek
Copy link
Contributor Author

https://github.com/pre-commit/pre-commit only works on the file-level, that is, check succeeds only if the whole file is properly formatted. What we want (for now) is to only check formatting of the changed lines.

@jiridanek jiridanek linked a pull request Aug 5, 2022 that will close this issue
Fixes #660 - Add pre-commit hooks #663
Merged
@jiridanek jiridanek self-assigned this Aug 5, 2022
@jiridanek jiridanek added this to the 2.1.0 milestone Aug 5, 2022
@jiridanek jiridanek added the task Minor work item - not a bug or feature label Aug 5, 2022
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
@jiridanek
Fixes skupperproject#660 - Add pre-commit hooks and clang-format check
399cfa5
jiridanek added a commit that referenced this issue Aug 5, 2022
@jiridanek
Fixes #660 - Add pre-commit hooks and clang-format check (#663)
efc9bbd
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
@jiridanek
Issue skupperproject#660 - Add additional pre-commit hooks
92d0efd
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
@jiridanek
Issue skupperproject#660 - Add additional pre-commit hooks
425a359
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
@jiridanek
Issue skupperproject#660 - Run clang-format for .json files as well
17dc06a
@jiridanek jiridanek linked a pull request Aug 5, 2022 that will close this issue
Issue #660 - Run clang-format for .json files as well #669
Merged
@jiridanek jiridanek mentioned this issue Aug 5, 2022
Closed
jiridanek added a commit that referenced this issue Aug 5, 2022
@jiridanek
Issue #660 - Run clang-format for .json files as well (#669)
2aa053b
@jiridanek jiridanek mentioned this issue Aug 8, 2022
Merged
@jiridanek jiridanek linked a pull request Aug 9, 2022 that will close this issue
Issue #660 - Add additional pre-commit hooks #662
Draft
jiridanek added a commit that referenced this issue Sep 1, 2022
@jiridanek
Issue #660 - Add documentation for git clang-format (#685)
6fa764e
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Oct 27, 2022
@jiridanek
Issue skupperproject#660 - Add additional pre-commit hooks
2e34b01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiridanek jiridanek

Labels
task Minor work item - not a bug or feature
Projects
None yet
Milestone
2.1.0
1 participant
@jiridanek