Add the from_time query parameter to the live tracking endpoints #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum... I'm not sure what's wrong with black here. Would be nice to have some more feedback in the logs. |
|
Other changes in this PR:
|
|
Hey @Turbo87 is there anything missing for this to be reviewed, merged and deployed ? No rush but please let me know if more work is expected from me here. Thanks ! |
|
ping ? |
sorry, I'm missing time to do a proper review at the moment. lots of other stuff going on. 😞 |
|
Is anybody at skylines interested in merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_timeallows specifying a start time as a UNIX timestamp for the endpoints:/live/<user_id>/json,/live/<users_id>,/tracking/latest.jsonThe endpoint
/live/<user_id>/jsonalready supports alatest_updatequery parameter which is the number of seconds since midnight of the day of the first point. If bothfrom_timeandlatest_updateare specified for this endpoint then the most recent condition wins (i.e. the conditions are ANDed).Also specifying
from_timedoes not allow retrieving earlier fixes than the maximum age for the endpoints (12h for #1 and #2 and 6h for #3).Could you please review @Turbo87.
fixes #2277
/cc @indyflyersoft