Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose reactionItem and reactionEvent #1095

Merged
merged 1 commit into from Dec 11, 2022

Conversation

grimmy
Copy link
Contributor

@grimmy grimmy commented Aug 10, 2022

Per the pr guidelines this should apparently been an issue, but seeing as nothing else in the library uses this and it was public until #57 was merged that we could forgo the issue.

@kanata2 kanata2 self-requested a review August 22, 2022 21:52
@grimmy
Copy link
Contributor Author

grimmy commented Aug 24, 2022

Since the lint is failing on unrelated code, I assume I need to rebase this?

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay. LGTM. Thanks!

@kanata2 kanata2 merged commit 5a47d3e into slack-go:master Dec 11, 2022
matthew-graves added a commit to matthew-graves/slack that referenced this pull request Jan 24, 2023
Hello! This PR is to match the websocket change for slack-go#1095 to expose the reactionEvent types in innerevents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants