add GetOtherTeam method #1118
Merged
add GetOtherTeam method #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanata2
reviewed
Oct 31, 2022
kanata2
added
the
feedback given
kanata2
removed
the
feedback given
This is put on hold as a future work. |
5 tasks
Sorry for the delay, I added the requested method in #1143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a chatbot that needs to be able to get information about users' teams to decide if/how to respond to them.
As has been noted in #980, the
GetTeamInfomethod doesn't expose the optionalteamargument that the Slack API accepts, meaning my bot can only get info about its own team.#981 attempted to fix this, but lacked backwards compatibility. This is an attempt to implement the functionality in a backwards-compatible way by creating a new
GetOtherTeamInfomethod, as had been suggested by @kanata2 in the discussion of #981I'm frankly a little unsure how to implement a meaningful test for this unfortunately, but I can confirm that
make pr-prepreported no issues.