Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to document optional field from housing Block and how it applies to Block Elements within? #2044

Open
rinormaloku opened this issue Feb 2, 2024 · 11 comments
Labels
auto-triage-skip Prevent this issue from being closed due to lack of activity docs M-T: Documentation work only enhancement M-T: A feature request for new functionality question M-T: User needs support to use the project

Comments

@rinormaloku
Copy link

rinormaloku commented Feb 2, 2024

Currently multi_external_select (link), requires you to select at least one option, otherwise, it fails the validation.

We worked around that by providing a default option none and people can remove it and add the options related to the content they are filling in.

However, it would be a better UX if the field is optional.

@filmaj
Copy link
Contributor

filmaj commented Feb 2, 2024

This is a feature request for the Block Kit select menus themselves, yes? Perhaps adding a required, or min_selected_items, field to enable this behaviour?

@filmaj filmaj added enhancement M-T: A feature request for new functionality question M-T: User needs support to use the project and removed untriaged labels Feb 2, 2024
@rinormaloku
Copy link
Author

Yes, specifically for the one retrieving options externally.

Both suggestions sound good to me.

@filmaj
Copy link
Contributor

filmaj commented Feb 5, 2024

I have raised this internally with the relevant engineering team. As I hear updates, I will report them back here.

@rinormaloku
Copy link
Author

This change will improve the UX drastically. Thank you Filmaj!

@filmaj
Copy link
Contributor

filmaj commented Feb 6, 2024

@rinormaloku one thing to try: can you put the multi-select menu inside an Input Block and set the Input Block's optional field to true?

@rinormaloku
Copy link
Author

@leartbeqiraj1 can you try this out and report back?

@filmaj
Copy link
Contributor

filmaj commented Feb 6, 2024

I gave it a go and indeed that does work, though it wasn't until a fellow Slack colleague pointed this out to me that I realized this was even an option! Something to improve in our documentation.. will need to think about how to tackle that.

@filmaj filmaj added docs M-T: Documentation work only and removed server-side-issue labels Feb 6, 2024
@filmaj filmaj changed the title Make multi_external_select fields optional How to document optional field from housing Block and how it applies to Block Elements within? Feb 6, 2024
@leartbeqiraj1
Copy link

I just tested it and I can verify that it works. Thanks a lot @filmaj and @rinormaloku

Copy link

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.

Copy link

As this issue has been inactive for more than one month, we will be closing it. Thank you to all the participants! If you would like to raise a related issue, please create a new issue which includes your specific details and references this issue number.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@filmaj filmaj reopened this Mar 25, 2024
@filmaj filmaj added auto-triage-skip Prevent this issue from being closed due to lack of activity and removed auto-triage-stale labels Mar 25, 2024
@filmaj
Copy link
Contributor

filmaj commented Mar 25, 2024

I'm reopening this as this is still outstanding to improve in our documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-triage-skip Prevent this issue from being closed due to lack of activity docs M-T: Documentation work only enhancement M-T: A feature request for new functionality question M-T: User needs support to use the project
Projects
None yet
Development

No branches or pull requests

3 participants