Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new @slack/verify-request package #1135

Open
4 tasks done
stevengill opened this issue Dec 17, 2020 · 4 comments
Open
4 tasks done

Create a new @slack/verify-request package #1135

stevengill opened this issue Dec 17, 2020 · 4 comments
Labels
auto-triage-skip enhancement M-T: A feature request for new functionality

Comments

@stevengill
Copy link
Member

Description

We should rip out the verifyRequestSignature code out of @slack/events-api and make it a stand alone package named @slack/verify-request.

What type of issue is this? (place an x in one of the [ ])

  • enhancement (feature request)

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@stevengill stevengill added the enhancement M-T: A feature request for new functionality label Dec 17, 2020
@seratch
Copy link
Member

seratch commented Dec 18, 2020

We should do this. As Bolt for JS has a similar code, we can replace the code in Bolt for JS with this new package in Bolt's next major version. As far as I know, the points to consider are:

  • Should the return value type be just a boolean value or an object holding a boolean result and error code?
  • How to keep the backward-compatibility of ReceiverAuthenticityError and its error mesage in Bolt

References:

@mim-Armand
Copy link

The verify-request does not seem to be working for the event calls, as the request body seems to be coming serialized now..

@seratch
Copy link
Member

seratch commented Aug 16, 2021

Hi @mim-Armand,

as the request body seems to be coming serialized now

This situation might be caused by some settings in your application. For instance, if your app is built with Express.js, having Express middleware may cause this. If you have more to ask on this, please feel free to create a new issue for the question! (this issue #1135 is for the task to create a new package, so please avoid continuing this conversation here)

@github-actions
Copy link

github-actions bot commented Dec 5, 2021

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-triage-skip enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

3 participants