Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning from chat.update #1674

Merged
merged 2 commits into from Oct 5, 2023
Merged

Remove warning from chat.update #1674

merged 2 commits into from Oct 5, 2023

Conversation

chrisronline
Copy link
Contributor

Summary

Recent changes to the chat.update API makes this warnings inaccurate and should not show to the user.

Requirements (place an x in each [ ])

filmaj
filmaj requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR! Just need to update the warning unit tests to go along with this change.

@filmaj filmaj added pkg:web-api applies to `@slack/web-api` semver:patch enhancement M-T: A feature request for new functionality labels Oct 5, 2023
@filmaj filmaj added this to the web-api@7.0 milestone Oct 5, 2023
@filmaj
Copy link
Contributor

filmaj commented Oct 5, 2023

You can update the tests or, when I eventually get to releasing 7.0.0 in the coming days/weeks, I can do this myself.

@chrisronline
Copy link
Contributor Author

@filmaj I'll do it!

filmaj
filmaj approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@filmaj filmaj merged commit 4a8eeac into main Oct 5, 2023
15 checks passed
@filmaj filmaj deleted the chat_update branch October 5, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj approved these changes

Assignees
No one assigned
Labels
enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Milestone
web-api@7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisronline @filmaj