Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-api: Add support for overriding token when using fileUploadV2 #1723

Merged
merged 2 commits into from Jan 16, 2024
Merged

web-api: Add support for overriding token when using fileUploadV2 #1723

merged 2 commits into from Jan 16, 2024
+58 −6

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jan 15, 2024

Fixes #1644.

@filmaj filmaj added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch labels Jan 15, 2024
@filmaj filmaj added this to the web-api@7.0 milestone Jan 15, 2024
@filmaj filmaj requested a review from a team January 15, 2024 20:14
@filmaj filmaj self-assigned this Jan 15, 2024
seratch
seratch approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue! LGTM 🚀

@filmaj filmaj merged commit e29f6a1 into main Jan 16, 2024
15 checks passed
@filmaj filmaj deleted the fileUploadV2-token-override branch January 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees

@filmaj filmaj

Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Projects
None yet
Milestone
web-api@7.0
Development

Successfully merging this pull request may close these issues.

filesUploadV2 does not foward token override argument to sub methods
2 participants
@filmaj @seratch