-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing exported types (Channel, etc) #1747
Comments
Hi, @mlynch! Thanks for submitting this issue! 🙇 Apologies for the inconveniences you're running into with types! It looks like we haven't released a new |
Thanks @hello-ashleyintech. I'm also noticing another typing issue with |
hi, @mlynch! 🙌 I should be able to start work on this within the next few weeks. To help with these efforts, I wanted to see if you could provide the previous version of |
@mlynch the requirement for an options object argument - even empty - is indeed a new change in v7. We may be able to adjust that on a per-method basis for methods where it makes sense. As for changes to response types, this is a more delicate task than adjusting arguments, as response shapes vary greatly depending on the Slack workspace operating against (the plan the workspace is on, the administration settings the workspace has set, and so on). If you have specific observations on what is missing or what could be improved (such as your |
Makes sense. I think the issue was more the documentation and some examples were out of date, but I'm sure that was a work in progress |
👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized. |
As this issue has been inactive for more than one month, we will be closing it. Thank you to all the participants! If you would like to raise a related issue, please create a new issue which includes your specific details and references this issue number. |
(Describe your issue and goal here)
Packages:
Select all that apply:
@slack/web-api
@slack/rtm-api
@slack/webhooks
@slack/oauth
@slack/socket-mode
@slack/types
I'm using
@slack/web-api
7.0.1 (which is pulling in@slack/types@2.11.0
). I've noticed many types returned in web api response objects are not exported, making it impossible/difficult to reference. For example,Channel
is not exported, so storing a reference to the channels returned fromclient.conversations.list
isn't clean:channelsInfo.channels
isChannel[]
butChannel
is not properly exported.There are many other examples of this in the library but I can't recall them at the moment.
The text was updated successfully, but these errors were encountered: