matchRecursive: make global non-sticky match with valueNames return an empty array if no matches found

Author: slevithan

src/addons/matchrecursive.js

@@ -238,7 +238,7 @@ export default (XRegExp) => {
             }
         }
 
-        if (global && !sticky && vN && vN[0] && str.length > lastOuterEnd) {
+        if (global && output.length > 0 && !sticky && vN && vN[0] && str.length > lastOuterEnd) {
             output.push(row(vN[0], str.slice(lastOuterEnd), lastOuterEnd, str.length));
         }
 

tests/spec/s-addons-matchrecursive.js

@@ -155,12 +155,11 @@ describe('XRegExp.matchRecursive addon:', function() {
                     valueNames: ['between', 'left', 'match', 'right']
                 })
             ).toEqual([]);
-            // TODO: Change behavior to match test (don't return `between` value with full string)
-            // expect(
-            //     XRegExp.matchRecursive('.', '<', '>', 'g', {
-            //         valueNames: ['between', 'left', 'match', 'right']
-            //     })
-            // ).toEqual([]);
+            expect(
+                XRegExp.matchRecursive('.', '<', '>', 'g', {
+                    valueNames: ['between', 'left', 'match', 'right']
+                })
+            ).toEqual([]);
         });
 
     });