Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated types def and tests #288

Merged
merged 4 commits into from Apr 22, 2020
Merged

Updated types def and tests #288

merged 4 commits into from Apr 22, 2020

Conversation

pristinesource
Copy link
Contributor

No description provided.

@pristinesource
Copy link
Contributor Author

Created here from DefinitelyTyped/DefinitelyTyped#43115 as per request from @jfahrenkrug

@josephfrazier josephfrazier merged commit 95eeebe into slevithan:master Apr 22, 2020
@josephfrazier
Copy link
Collaborator

Thanks, especially for the link to the DefinitelyTyped PR! I eyeballed this one against as a sanity check, and it seems fine. I'm hoping to be able to make a new release sometime this week.

@josephfrazier
Copy link
Collaborator

I'm hoping to be able to make a new release sometime this week.

Hmm actually, it looks like I no longer have NPM public permissions, according to npm owner ls xregexp, so we might have to wait for @slevithan if we want to get a new version out, containing the changes since v4.3.0.

@slevithan
Copy link
Owner

@josephfrazier I haven’t changed anything so I think you should still be able to publish. I just checked the xregexp package settings on npmjs.com and you have write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants