From 080f592b16f021a3a8e43d95ca8f57b87ddcf4e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaroslav=20Hansl=C3=ADk?= Date: Sat, 22 Oct 2022 17:42:49 +0200 Subject: [PATCH] SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation: Fixed false positive with self::CONSTANT --- .../Namespaces/FullyQualifiedClassNameInAnnotationSniff.php | 4 ++++ .../data/fullyQualifiedClassNameInAnnotationNoErrors.php | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php b/SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php index bdd2a22db..475608e9e 100644 --- a/SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php +++ b/SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php @@ -109,6 +109,10 @@ public function process(File $phpcsFile, $docCommentOpenPointer): void ? $constantFetchNode->className : $constantFetchNode->name; + if ($typeHint === 'self') { + continue; + } + $fullyQualifiedTypeHint = $isClassConstant ? NamespaceHelper::resolveClassName( $phpcsFile, diff --git a/tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php b/tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php index a983b3b80..2f6886be0 100644 --- a/tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php +++ b/tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php @@ -178,7 +178,7 @@ public function withNever() } /** - * @method sortBy(callable $path, int $order = \SORT_DESC, int $sort = \SORT_NUMERIC) + * @method sortBy(callable $path, int $order = \SORT_DESC, int $sort = \SORT_NUMERIC, int $flags = self::FLAG) */ class ConstantExpression {