Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize development environment #15

Open
slifty opened this issue Nov 15, 2018 · 0 comments
Open

Modernize development environment #15

slifty opened this issue Nov 15, 2018 · 0 comments

Comments

@slifty
Copy link
Owner

slifty commented Nov 15, 2018 •
edited

I suppose a lot changes in two years.

I would like:

  • The code base to be written in ES6 / linted / etc. This seems like a reasonable guide
  • Travis build to not completely break.
  • Update travis not use checks nodes Node 0.12
  • Clean up old packages and random config files that aren't used / needed by the project
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Move test packages to dev dependencies
889fdca 
Mocah and Should are only used for testing purposes and absolutely do
not belong as a core dependency.

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Update node version
53f966c 
Going forward opened captions is going to built assuming Node 11

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Add socket.io dependency
0d4e397 
I honestly don't know when this got removed, but, that's why Travis has
been breaking this whole time I bet.

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Add socket.io dependency
04245ef 
I honestly don't know when this got removed, but, that's why Travis has
been breaking this whole time I bet.

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Specify more recent node version for travis
1843b8d 
Travis might as well test on 11.0.1

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Update test packages
d921b2c 
The project was using a very old version of Mocah and should packages.
This brings them up to the current stable versions of each.  This
actually exposed a mistake in the tests as written, which forgot to
properly close the Opened Captions server before declaring the tests
over in some cases.

The tests still have an issue, which also exposes a mistake that will
need to be fixed in a separate commit.

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Specify more recent node version for travis
182df71 
Travis might as well test on 11.0.1

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Update test packages
311b5f2 
The project was using a very old version of Mocah and should packages.
This brings them up to the current stable versions of each.  This
actually exposed a mistake in the tests as written, which forgot to
properly close the Opened Captions server before declaring the tests
over in some cases.

The tests still have an issue, which also exposes a mistake that will
need to be fixed in a separate commit.

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Update test packages
6219ff3 
The project was using a very old version of Mocah and should packages.
This brings them up to the current stable versions of each.  This
actually exposed a mistake in the tests as written, which forgot to
properly close the Opened Captions server before declaring the tests
over in some cases.

The tests still have an issue, which also exposes a mistake that will
need to be fixed in a separate commit.

Issue #15 Modernize development environment
@slifty slifty mentioned this issue Nov 15, 2018
Merged
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Remove use of lodash
55b2f97 
Lodash is a library that simply is not needed any more, and it had
a major security vulnerability to boot.  This swaps out some of what
lodash was offering since much of it is now baked into ES2015.  Lodash
itself will be removed in a future commit

Issue #15 Modernize development environment
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Remove lodash
f59ae01 
Thanks to the wonderful
https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore for
providing all the easy ways to remove lodash!

This takes out a dependency entirely from the project, since it is no
longer actually being used anywhere in the code base.

Issue #15 Modernize development environment
@slifty slifty mentioned this issue Nov 15, 2018
Merged
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Remove Express
2342e4b 
Express is not actually used in this project at all; it used to be,
before opened captions was turned into an npm package (and the demo
server was part of this code base).

Let's get this out of here!

Issue #15 Modernize development environment
@slifty slifty mentioned this issue Nov 15, 2018
Merged
slifty added a commit that referenced this issue Nov 15, 2018
@slifty
Remove bluebird
ab07722 
Bluebird is another relic from the past of this project, and is not
actually used anywhere.  This commit also sneaks out the import of the
http module since that isn't used either.

Issue #15 Modernize development environment
This was referenced Nov 15, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slifty