Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only render tip to error log if plain text renderer is used #3321

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Only render tip to error log if plain text renderer is used #3321

wants to merge 1 commit into from

Conversation

akrabat
Copy link
Member

@akrabat akrabat commented May 9, 2024

If the logErrorRenderer is not the plain text renderer then we must not render the tips message as this will break the structured format of the message that's been rendered.

Closes #3317

@akrabat
Only render tip to error log if plain text renderer is used
bb96d39 
If the logErrorRenderer is not the plain text renderer then we must not
render the tips message as this will break the structured format of the
message that's been rendered.

Closes slimphp#3317
@akrabat akrabat added this to the 4.14.0 milestone May 9, 2024
@akrabat akrabat requested review from geggleto and l0gicgate May 9, 2024 19:43
@coveralls
Copy link

Coverage Status

coverage: 99.427%. remained the same
when pulling bb96d39 on akrabat:3317-do-not-write-tips-message-to-formatted-output
into ad92887 on slimphp:4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geggleto geggleto Awaiting requested review from geggleto

@l0gicgate l0gicgate Awaiting requested review from l0gicgate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.

Using wrong flag to write to error log in ErrorHandler
2 participants
@akrabat @coveralls