Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report exit code for the target containerized application if/when it crashes and when it exits #561

Open
kcq opened this issue Aug 17, 2023 · 5 comments
Labels

Comments

@kcq
Copy link
Member

kcq commented Aug 17, 2023

It's useful to know the exit code of the target application if the target app exited or crashed during the minification process. For many containerized apps it's an important signal that will indicate if the minified container image is good.

This feature is also related to the new app-exit continue-after mode allows the main application to observe the target application until it's done executing. The app-exit mode makes it easier to minify cli / non-server applications, so you don't have to use the timeout mode, which may not easy to guess for some apps.

@kcq kcq added the feature label Aug 17, 2023
@utibeabasi6
Copy link

i can take a look at this if no one has already

@kcq
Copy link
Member Author

kcq commented Aug 24, 2023

@utibeabasi6 let me know if you need any pointers

@utibeabasi6
Copy link

utibeabasi6 commented Aug 25, 2023 via email

@reetasingh
Copy link
Contributor

@kcq I am interested in working on this feature. Looking for additional pointers . Are we looking to implement the TBD here https://github.com/slimtoolkit/slim/blob/master/pkg/app/master/commands/profile/handler.go#L439?

@kcq
Copy link
Member Author

kcq commented Sep 27, 2023

@kcq I am interested in working on this feature. Looking for additional pointers . Are we looking to implement the TBD here https://github.com/slimtoolkit/slim/blob/master/pkg/app/master/commands/profile/handler.go#L439?

@reetasingh this is related, but it's something different... it's the placeholder for the "app exit" "continue after" mode. it's a WIP feature that's mostly done (a few things to wrap up there). yes, it will have the status code there, but in this case we want the status code regardless of the selected "continue after" mode. It's a tricky enhancement because it requires enhancing the main app and also the sensor to propagate the application exit status code through the related sensor events. Feel free to take on it, but at this point in time I won't have a lot of cycles to provide support, so you'd be on your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants