Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mutex for outgoing API calls #340

Open
builder-247 opened this issue Mar 15, 2020 · 0 comments
Open

Implement mutex for outgoing API calls #340

builder-247 opened this issue Mar 15, 2020 · 0 comments
Assignees
@builder-247

Comments

@builder-247
Copy link
Member

Currently if multiple requests are made close to each other that require using Mojang or Hypixel APIs, multiple requests are sent. For example when viewing uncached player's stats via Slothpixel UI, 2 requests are sent to Mojang API resolving the username. This behaviour has many disadvantages - rate limits & resources are used unnecessarily.

Ideally when this happens, only one request is sent and the other data consumers wait for the original API response.

The state should be managed with redis for example, allowing multiple web instances to coexist sharing the mutex.
@builder-247 builder-247 added the important Issues that should be focused on label Mar 15, 2020
@builder-247 builder-247 self-assigned this Apr 3, 2020
@builder-247 builder-247 removed the important Issues that should be focused on label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@builder-247 builder-247

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@builder-247