Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCB] Improve GCB verification tracking issue #149

Open
4 tasks
asraa opened this issue Mar 9, 2023 · 2 comments
Open
4 tasks

[GCB] Improve GCB verification tracking issue #149

asraa opened this issue Mar 9, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@asraa
Copy link
Collaborator

asraa commented Mar 9, 2023

This issue tracks action items left for GCB verification support.

Currently, the workflows run on two schedules, a biweekly one and a daily one. The biweekly one triggers a build, while the daily one retrieves the latest build from that image and verifies it.

Currently, we test:

Things to note:

  • We cannot test branch or tag options in the slsa-verifier for GCB - we only test that we can verify these triggers - so there doesn't seem to be a point in testing branch1. Tag verification is skipped because we aren't verifying on GITHUB_REF_TYPE tag (we build on tag, but verify on daily schedule)
  • Some workflows do not rebuilds on workflow_dispatch to prevent overbuilding. Consider an input here, like this - on the other hand, you can manually trigger builds by clicking RUN on the trigger page
  • Only push to branch and tag are supported for GitHub repository triggers in GCB.

cc @laurentsimon @ianlewis

@asraa asraa self-assigned this Mar 9, 2023
@laurentsimon
Copy link
Collaborator

Do you know what 1st vs 2nd source generation is?

@asraa
Copy link
Collaborator Author

asraa commented Mar 9, 2023

Do you know what 1st vs 2nd source generation is?

Not really, there are some docs. https://cloud.google.com/build/docs/repositories

It seems like its more about the way that the connection is done (through GitHub Apps or auth?)

@ianlewis ianlewis added the enhancement New feature or request label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants