Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tech debt] Refactor verify_provenance_authenticity #179

Open
ianlewis opened this issue May 1, 2023 · 0 comments
Open

[tech debt] Refactor verify_provenance_authenticity #179

ianlewis opened this issue May 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented May 1, 2023

This function has a lot of special casing for each builder and is getting pretty hard to edit. We should either break up the function per builder or by verifier command (e.g. verify-artifact, verify-image, verify-npm-package) as the options are different for each command.

example-package/.github/workflows/scripts/e2e-verify.common.sh

Line 209 in 7987713

verify_provenance_authenticity() {

@ianlewis ianlewis added the enhancement New feature or request label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianlewis