Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge trigger scripts #238

Open
ianlewis opened this issue Jul 18, 2023 · 1 comment · Fixed by #239
Open

Merge trigger scripts #238

ianlewis opened this issue Jul 18, 2023 · 1 comment · Fixed by #239
Labels
enhancement New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Jul 18, 2023

These scripts can trigger a push, release, or workflow_dispatch event but they can do that depending on the e2e workflow file name. So we should be able to merge them.

We should probably refactor a bit so that there isn't too much hard-to-read code branching.

There are a few things that need to happen differently based on a few things:

Workflow:

  • For nodejs workflows the Node package needs to be updated to bump the version.
  • For all other tests we don't need to do anything special.

Event type:

@ianlewis ianlewis added the enhancement New feature or request label Jul 18, 2023
@ianlewis ianlewis changed the title Merge e2e-push.sh, e2e-nodejs-push.sh, e2e-create-release.sh, and e2e-dispatch.sh Merge trigger scripts Jul 18, 2023
@ianlewis ianlewis linked a pull request Jul 20, 2023 that will close this issue
@ianlewis ianlewis reopened this Aug 8, 2023
ianlewis added a commit that referenced this issue Aug 10, 2023
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Copy link
Member Author

The e2e-bootstrap.sh script is done but we still need to update all tears to use the new script and remove the old scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant