Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor e2e_verify_common_* #251

Open
ianlewis opened this issue Jul 31, 2023 · 0 comments
Open

Refactor e2e_verify_common_* #251

ianlewis opened this issue Jul 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Jul 31, 2023 •
edited

We should remove e2e_verify_common_all and replace with e2e_verify_common_all_v02. We may still need to make a distinction between BYOB and non-BYOB builders but we should rename these functions to something more descriptive like e2e_verify_common_all_v02 and e2e_verify_common_all_byob_v02 etc.

Right now I believe it is:

  • e2e_verify_common_all -> non-BYOB SLSA v0.2 builders/generators
  • e2e_verify_common_all_v02 -> BYOB SLSA v0.2 builders (e.g. Node.js builder)
@ianlewis ianlewis added the enhancement New feature or request label Jul 31, 2023
@ianlewis ianlewis changed the title Remove e2e_verify_common_all Refactor e2e_verify_common_* Jul 31, 2023
@ianlewis ianlewis mentioned this issue Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianlewis