Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-submits for internal actions #1068

Open
4 of 10 tasks
ianlewis opened this issue Oct 17, 2022 · 1 comment
Open
4 of 10 tasks

Add pre-submits for internal actions #1068

ianlewis opened this issue Oct 17, 2022 · 1 comment
Labels
area:tests An issue with tests (unit, e2e, etc.) type:feature New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Oct 17, 2022

pre-submits call the reusable workflows but the version of internal actions in those workflows is pinned. So actions do not run at the version in the pull request and thus we miss problems with changes to the actions.

We can call the actions directly in a pre-submit workflow.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-an-action-in-the-same-repository-as-the-workflow

@ianlewis ianlewis added type:feature New feature or request area:tests An issue with tests (unit, e2e, etc.) labels Oct 17, 2022
@ianlewis
Copy link
Member Author

We can maybe omit some basic tests since #1075 is unpinning the internal actions. Though secure-builder-checkout will still be pinned so we may want a pre-submit for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests An issue with tests (unit, e2e, etc.) type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant