Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: usage of 'ca token' unclear #1065

Open
philfry opened this issue Nov 16, 2023 · 0 comments
Open

[docs]: usage of 'ca token' unclear #1065

philfry opened this issue Nov 16, 2023 · 0 comments
Assignees
Labels
docs Documentation needs triage Waiting for discussion / prioritization by team
Milestone

Comments

@philfry
Copy link

philfry commented Nov 16, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to document this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Affected area/feature

Re: step ca token

(1) The help text states that --not-after and --not-before are used for the certificate validity. After (running into this and) looking into command/ca/token.go I found that these flags are for the token validity, not the certificate.

(2) --cert-not-after and --cert-not-before are described as This flag is only supported on SSH certificates. But I found no evidence in command/ca/token.go or in utils/cautils that this is true – it seems to work both for ssh and non-ssh tokens. Also, if it only applied to ssh certs, dedicated non-ssh cert options would be missing.

@philfry philfry added docs Documentation needs triage Waiting for discussion / prioritization by team labels Nov 16, 2023
@hslatman hslatman added this to the v0.25.1 milestone Nov 21, 2023
@hslatman hslatman modified the milestones: v0.25.1, v0.25.2 Nov 29, 2023
@hslatman hslatman modified the milestones: v0.25.2, v0.25.3 Feb 20, 2024
@hslatman hslatman modified the milestones: v0.26.0, v0.26.1 Mar 29, 2024
@hslatman hslatman modified the milestones: v0.26.1, v0.26.2 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

No branches or pull requests

3 participants