Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: step-cli uses gotestsum but does not build it #820

Open
dermotbradley opened this issue Dec 31, 2022 · 1 comment
Open

[Bug]: step-cli uses gotestsum but does not build it #820

dermotbradley opened this issue Dec 31, 2022 · 1 comment
Assignees
Labels
bug needs triage Waiting for discussion / prioritization by team

Comments

@dermotbradley
Copy link

Steps to Reproduce

Hi. I'm the Alpine package maintainer for step-cli (and step-certificates).

When step-cli 0.23.0 was released and I packaged it up I found that "make test" was failing whereas it had worked fine in previous releases.

This was due to the change to use "gotestsum". However in a "make build", "make test" sequence gotestsum is never built and that's why the tests fail.

I had to make a 2 line change (including remove a $(GOFLAGS) reference) to make/common.mk to fix this: https://git.alpinelinux.org/aports/tree/community/step-cli/01-fix-tests.patch

Your Environment

  • OS - Alpine Linux
  • step CLI Version - 0.23.0

Expected Behavior

"make test" to work as in previous releases.

Actual Behavior

"make test" failed as gotestsum was not present to run.

Additional Context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@dermotbradley dermotbradley added bug needs triage Waiting for discussion / prioritization by team labels Dec 31, 2022
@dopey dopey self-assigned this Jan 11, 2023
@dopey
Copy link
Contributor

dopey commented Mar 23, 2023

Hey @dermotbradley 👋. Thanks for opening the issue!

And apologies that it has taken us so long to get back to you :[

Would it be possible to call make bootstrap -> make build -> make test (adding make bootstrap)? We prefer to keep the necessary install in the bootstrap target, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

No branches or pull requests

2 participants