Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 From node_modules Not Transformed Properly #114

Closed
3 tasks done
SantoJambit opened this issue Dec 12, 2019 · 2 comments
Closed
3 tasks done

ES6 From node_modules Not Transformed Properly #114

SantoJambit opened this issue Dec 12, 2019 · 2 comments
Assignees
Labels
bug Something isn't working cli Concerns the piral-cli application. dependencies Pull requests that update a dependency file parcel Concerns the integration of the Parcel bundler in the CLI.
Milestone

Comments

@SantoJambit
Copy link
Contributor

Bug Report

ES6 code from node_modules leaks into the dist .js files as it's getting ignored by the transformers.

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you perform a search in the issues?

Environment Details and Version

Version 0.9.2

Description

When You create a build that imports dependencies from node_modules, which are written in es6, for example with template strings, then these will not be converted to es5 compatible js.
This is an issue if you need to support IE 11.

Steps to Reproduce

  1. Create a shell application, build it
  2. check the resulting .js file for template strings.. you'll find some.

Expected behavior

No ES6 in the dist files.

Actual behavior

Template strings found in the dist files.

Possible Origin / Solution

This is actually a parcel issue: parcel-bundler/parcel#2013
But it seems to be ignored.

@SantoJambit SantoJambit added the bug Something isn't working label Dec 12, 2019
@FlorianRappl FlorianRappl added the cli Concerns the piral-cli application. label Dec 12, 2019
@FlorianRappl FlorianRappl added this to the 0.10.0 milestone Dec 12, 2019
@FlorianRappl FlorianRappl added the dependencies Pull requests that update a dependency file label Dec 12, 2019
@FlorianRappl
Copy link
Contributor

Thanks for the report. We'll take care of it.

Potentially we'll go for a simple solution to just (for builds only, i.e., no debugging) apply a post-build action to transform all created bundles according to the .browserlist setting. Not sure yet how to generalize, but we'll figure something out!

🍻

@FlorianRappl FlorianRappl changed the title node_modules being ignored during build ES6 From node_modules Not Transformed Properly Dec 12, 2019
@FlorianRappl FlorianRappl added the in-review The item is currently being reviewed. label Dec 12, 2019
@FlorianRappl FlorianRappl self-assigned this Dec 12, 2019
@FlorianRappl FlorianRappl modified the milestones: 0.10.0, 0.9.3 Dec 12, 2019
@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. and removed in-review The item is currently being reviewed. in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. labels Dec 15, 2019
@FlorianRappl
Copy link
Contributor

Landed in preview and develop.

@FlorianRappl FlorianRappl added the parcel Concerns the integration of the Parcel bundler in the CLI. label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Concerns the piral-cli application. dependencies Pull requests that update a dependency file parcel Concerns the integration of the Parcel bundler in the CLI.
Projects
None yet
Development

No branches or pull requests

2 participants