Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript timestamp input serialization should not remove milliseconds #1278

Closed
rkyker opened this issue May 13, 2024 · 0 comments · Fixed by #1289
Closed

TypeScript timestamp input serialization should not remove milliseconds #1278

rkyker opened this issue May 13, 2024 · 0 comments · Fixed by #1289
Assignees
Labels
pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@rkyker
Copy link

rkyker commented May 13, 2024

As per the Smithy documentation 6.4. timestampFormat trait:

  • date-time: "...with optional millisecond precision..."
  • epoch-seconds: "...with optional millisecond precision (for example, 1515531081.123). Values that are more granular than millisecond precision SHOULD be truncated to fit millisecond precision. "

Currently in: HttpProtocolGeneratorUtils - getTimestampInputParam()

In both cases the milliseconds (if present) should be passed through so that the input timestamp value is not modified by the serialization.

In particular, we are using the date-time format and need the milliseconds passed through.

@rkyker rkyker changed the title Typescript timestamp input serialization should not remove milliseconds TypeScript timestamp input serialization should not remove milliseconds May 13, 2024
@kuhe kuhe self-assigned this May 22, 2024
@kuhe kuhe added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label May 22, 2024
@kuhe kuhe added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants