fix: ignore css chunk (#689)

gregberge · Jan 24, 2021 · 6926e19 · 6926e19
1 parent c8eb7f7
commit 6926e19
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/packages/server/src/ChunkExtractor.js b/packages/server/src/ChunkExtractor.js
@@ -171,6 +171,11 @@ function isValidChunkAsset(chunkAsset) {
   return chunkAsset.scriptType && !HOT_UPDATE_REGEXP.test(chunkAsset.filename)
 }
 
+const JS_FILE = /\.js$/
+function checkIfChunkIncludesJs(chunkInfo) {
+  return chunkInfo.files.some(file => JS_FILE.test(file.split('?')[0]))
+}
+
 class ChunkExtractor {
   constructor({
     statsFile,
@@ -201,6 +206,12 @@ class ChunkExtractor {
     return chunkGroup
   }
 
+  getChunkInfo(chunkId) {
+    const chunkInfo = this.stats.chunks.find(chunk => chunk.id === chunkId)
+    invariant(chunkInfo, `cannot find chunk (chunkId: ${chunkId}) in stats`)
+    return chunkInfo
+  }
+
   createChunkAsset({ filename, chunk, type, linkType }) {
     const resolvedFilename =
       typeof filename === 'object' && filename.name ? filename.name : filename
@@ -269,7 +280,17 @@ class ChunkExtractor {
   getChunkDependencies(chunks) {
     const one = chunk => {
       const chunkGroup = this.getChunkGroup(chunk)
-      return chunkGroup.chunks
+
+      // ignore chunk that only contains css files.
+      return chunkGroup.chunks.filter(chunkId => {
+        const chunkInfo = this.getChunkInfo(chunkId)
+
+        if (!chunkInfo) {
+          return false
+        }
+
+        return checkIfChunkIncludesJs(chunkInfo)
+      })
     }
 
     if (Array.isArray(chunks)) {

diff --git a/packages/webpack-plugin/src/index.js b/packages/webpack-plugin/src/index.js
@@ -22,12 +22,19 @@ class LoadablePlugin {
       hash: true,
       publicPath: true,
       assets: true,
-      chunks: false,
+      chunks: true,
       modules: false,
       source: false,
       errorDetails: false,
       timings: false,
     })
+
+    stats.chunks = stats.chunks.map(chunk => ({
+      ...chunk,
+      modules: [], // in case modules array is big
+      origins: [], // in case origins array is big
+    }))
+
     const result = JSON.stringify(stats, null, 2)
 
     if (this.opts.writeToDisk) {