Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make-dir instead of mkdirp #544

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Conversation

pustovalov
Copy link
Contributor

Summary

warning @loadable/webpack-plugin > mkdirp@0.5.4: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)

https://github.com/isaacs/node-mkdirp/blob/master/CHANGELOG.md

also

@theKashey
Copy link
Collaborator

Ok, so updated mkdirp requires node>=10, and we have to follow.

@pustovalov
Copy link
Contributor Author

Found one more inconsistency, webpack 4 supports "node": ">=6.11.5"
https://github.com/webpack/webpack/blob/webpack-4/package.json#L88

I see a few options:

  1. Update mkdirp and drop node 8
  2. Switch to another package: https://github.com/sindresorhus/make-dir
    like babel did:
    babel/babel-loader@47958ca

@theKashey
Copy link
Collaborator

The second option sounds better, and the make-dir library is actually doing only what we need, not a dozen other things.

@pustovalov pustovalov changed the title Update mkdirp, drop node 8 Use make-dir instead of mkdirp Mar 25, 2020
@gregberge gregberge merged commit 5a9c33b into gregberge:master Apr 5, 2020
@gregberge
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants