feat: support multiple Webpack runtimes

[wvanrensselaer]

Addresses: #635

Summary

We have a case where we're running multiple Webpack runtimes on the same page which both use Loadable. This change adds an optional chunkLoadingGlobal option to LoadablePlugin and loadableReady which namespaces jsonpFunction or chunkLoadingGlobal.

Test plan

I didn't see unit tests for LoadablePlugin but I tested in a local application which rendered two Webpack apps in the same page. I can push this to a repo if you'd like. It correctly adds the namespace:

namespace: 'header'

(window["__header__LOADABLE_LOADED_CHUNKS__"] = window["__header__LOADABLE_LOADED_CHUNKS__"] || []).push([["foo"],{

namespace: 'content'

(window["__content__LOADABLE_LOADED_CHUNKS__"] = window["__content__LOADABLE_LOADED_CHUNKS__"] || []).push([["foo"],{

[wvanrensselaer]

Probably a breaking change since namespace is separately used for getRequiredChunkKey above. Maybe I should add a separate more explicit option. Maybe just a chunkLoadingGlobal option for both loadableReady and LoadablePlugin which overrides the whole thing?

[theKashey]

everything looks good 👍

[wvanrensselaer]

Thanks @theKashey, anything more needed from my side? I'm not able to merge due to some CI checks.

Any concern with my comment about the namespace in loadableReady? Currently that namespace is just for the ChunkExtractor key (__LOADABLE_REQUIRED_CHUNKS__). Overloading it for the chunkLoadingGlobal (__LOADABLE_LOADED_CHUNKS__) requires also setting it in the LoadablePlugin which would make this semver major.

[wvanrensselaer]

Updated to differentiate from the existing namespace option in loadableReady and avoid breaking update.

[gileck]

@wvanrensselaer Thanks for this PR, We encountered the same issue and this would fix it for us, I like the solution with the new option in loadableReady - make sense!
When are you planning to merge it?
Thanks!

[wvanrensselaer]

Just waiting on @theKashey, is this good to merge?

[theKashey]

🤯 I didn't merge it. :coneofshame:

[gileck]

🤯 I didn't merge it. :coneofshame:

Hi @theKashey, When do you plan to merge it? we are waiting for this bug fix to resolve an issue we have with multiple components on the same site. Thanks

[theKashey]

Hey, trying to find some extra time to go through all open important tasks and do proper testing before the merge - there are a few moments that worries me a little - but yet with no luck.

[theKashey]

Released 5.15.0