Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong command logged to delete a VM from inventory #331

Open
cmoulliard opened this issue Jun 15, 2023 · 3 comments
Open

Wrong command logged to delete a VM from inventory #331

cmoulliard opened this issue Jun 15, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request module::ansible

Comments

@cmoulliard
Copy link
Member

Issue

The following command to be executed

TASK [passstore/ansible_inventory : If the folder already exists, fail!] ******************************************************************************************************************************************************
Thursday 15 June 2023  14:52:31 +0200 (0:00:00.439)       0:00:05.173 ********* 
fatal: [localhost]: FAILED! => {"changed": false, "msg": ["The test host folder already exists in pass, to execute the creation first remove that folder using the required playbook.", "$ ansible-playbook ansible/playbook/passstore/passstore_controller_inventory_remove.yml -e vm_name=test -e pass_provider=openstack"]}

do not exist

ansible-playbook ansible/playbook/passstore/passstore_controller_inventory_remove.yml -e vm_name=test -e pass_provider=openstack 
ERROR! the playbook: ansible/playbook/passstore/passstore_controller_inventory_remove.yml could not be found
@cmoulliard cmoulliard added bug Something isn't working module::ansible labels Jun 15, 2023
@cmoulliard
Copy link
Member Author

ansible-playbook ansible/playbook/passstore/passstore_controller_inventory_remove.yml

In fact, the command exists but should be executed at the root of the project and not under ansible as documented !
We should review such a point to improve it. Proposition: we tell to the user that all the ansible commands should be executed at the root of the project or under ansible. If we choose the option 2), then the commands logged should not include ./ansible/....

WDYT ? @jacobdotcosta

@cmoulliard cmoulliard added enhancement New feature or request and removed bug Something isn't working labels Jun 15, 2023
@jacobdotcosta
Copy link
Member

jacobdotcosta commented Aug 31, 2023

Initially the playbooks were to be executed from within the ansible folder as happened with other tools that were documented to be executed from the point of the docs.

At this moment all the commands should be executed at the root folder of the project so there should be no doubt about where to execute them. In the README.adoc file on the root of the project there's a ⚠️ WARNING message stating that "All the commands mentioned on this project are to be executed at the root folder of the repository, except if stated otherwise.".

If it's still documented otherwise anywhere it should be fixed.

@cmoulliard
Copy link
Member Author

If it's still documented otherwise anywhere it should be fixed.

Please check and fix them @jacobdotcosta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module::ansible
Projects
None yet
Development

No branches or pull requests

2 participants