Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing code and introduce snapshots #113

Closed
abdulhannanali opened this issue May 16, 2021 · 2 comments
Closed

Improve testing code and introduce snapshots #113

abdulhannanali opened this issue May 16, 2021 · 2 comments
Labels

Comments

@abdulhannanali
Copy link

The testing code right now is spread between node-tap and jest. Moreover, the process of introducing properties and updating fixtures is quite cumbersome and not for everyone.

This could be improved, in order to make the testing seamless and smoother. I propose following changes.

  • Migration of all tests to Jest
  • Use of snapshotting for fixture expected dependency trees comparison, it would give us better performance along with easier management and updating
  • Further modularization of the test code
@lili2311
Copy link
Contributor

hi @abdulhannanali thanks for raising this, we are indeed in the process of migrating to jest. Completely with you on the snapshots :)

@abdulhannanali
Copy link
Author

Great to hear that! Hope the migration goes well. 👍

@github-actions github-actions bot added the Stale label May 15, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants