Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add code client detail error [NEBULA-1511] #4922

Merged
merged 2 commits into from
Nov 14, 2023
Merged

feat: add code client detail error [NEBULA-1511] #4922

merged 2 commits into from
Nov 14, 2023

Conversation

nick-watson
Copy link
Contributor

@nick-watson nick-watson commented Nov 7, 2023 •
edited

What does this PR do?

  • Implements error handling and user messaging for code client errors containing error details
  • Updates code-client package

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/unit/snyk-code/snyk-code-test.spec.ts

Generated by 🚫 dangerJS against a8615b6

@nick-watson nick-watson force-pushed the feat/add-code-client-detail-error branch 2 times, most recently from a120bb0 to f88d296 Compare November 8, 2023 09:38
@nick-watson nick-watson mentioned this pull request Nov 8, 2023
Merged
2 tasks
@nick-watson nick-watson force-pushed the feat/add-code-client-detail-error branch from f88d296 to 78e8a58 Compare November 10, 2023 15:01
@nick-watson nick-watson marked this pull request as ready for review November 10, 2023 15:02
@nick-watson nick-watson requested review from a team as code owners November 10, 2023 15:02
@nick-watson nick-watson changed the title feat: add code client detail error feat: add code client detail error [NEBULA-1511] Nov 10, 2023
@metju90 metju90 enabled auto-merge (squash) November 13, 2023 12:25
@metju90 metju90 force-pushed the feat/add-code-client-detail-error branch 5 times, most recently from ae3218f to 82c0c05 Compare November 13, 2023 15:01
@metju90 metju90 force-pushed the feat/add-code-client-detail-error branch from 82c0c05 to ae3218f Compare November 14, 2023 10:01
@metju90 metju90 force-pushed the feat/add-code-client-detail-error branch from ae3218f to a8615b6 Compare November 14, 2023 10:03
@metju90 metju90 merged commit 1cb1fe5 into master Nov 14, 2023
12 checks passed
@metju90 metju90 deleted the feat/add-code-client-detail-error branch November 14, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novalex novalex novalex approved these changes

@metju90 metju90 metju90 approved these changes

@PeterSchafer PeterSchafer PeterSchafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nick-watson @novalex @metju90 @PeterSchafer