Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set endpoint & org configuration for legacy CLI depending on context #4931

Merged
merged 9 commits into from
Nov 20, 2023

Conversation

PeterSchafer
Copy link
Contributor

@PeterSchafer PeterSchafer commented Nov 14, 2023

What does this PR do?

Ensure to set the endpoint and org for the legacy CLI based on the Extensible CLI configuration, if they are explicitly set.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@PeterSchafer PeterSchafer requested a review from a team as a code owner November 14, 2023 13:30
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wunderbest

@bastiandoetsch bastiandoetsch enabled auto-merge (squash) November 14, 2023 13:32
@PeterSchafer PeterSchafer force-pushed the fix/HEAD-1031_ls_extension_config branch from b586aa4 to 0046c56 Compare November 15, 2023 17:31
@PeterSchafer PeterSchafer changed the title fix: set endpoint configuration for legacy CLI fix: set endpoint & org configuration for legacy CLI depending on context Nov 15, 2023
@PeterSchafer PeterSchafer force-pushed the fix/HEAD-1031_ls_extension_config branch from 0fa3e1f to 1267661 Compare November 20, 2023 14:27
@bastiandoetsch bastiandoetsch merged commit 4eb072f into master Nov 20, 2023
7 of 12 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/HEAD-1031_ls_extension_config branch November 20, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants