Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include Snyk CLI as a generator tool in SBOM documents #4945

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

mcombuechen
Copy link
Contributor

@mcombuechen mcombuechen commented Nov 23, 2023

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

What does this PR do?

This upgrades the snyk/cli-extension-sbom to include a tool entry for the Snyk CLI in generated SBOM documents.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@mcombuechen mcombuechen requested review from a team as code owners November 23, 2023 08:42
@mcombuechen mcombuechen force-pushed the feature/LINK-686-upgrade-sbom-ext branch from b6bf801 to aaa7993 Compare November 23, 2023 08:45
@mcombuechen mcombuechen force-pushed the feature/LINK-686-upgrade-sbom-ext branch from aaa7993 to 3ff27f7 Compare November 24, 2023 11:31
@mcombuechen mcombuechen enabled auto-merge (squash) November 24, 2023 11:31
@mcombuechen mcombuechen force-pushed the feature/LINK-686-upgrade-sbom-ext branch from 3ff27f7 to 7576702 Compare November 24, 2023 13:21
@mcombuechen mcombuechen merged commit 97746db into master Nov 24, 2023
12 checks passed
@mcombuechen mcombuechen deleted the feature/LINK-686-upgrade-sbom-ext branch November 24, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants