Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump nodejs-parser to 1.52.8 #4952

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

JamesPatrickGill
Copy link
Member

@JamesPatrickGill JamesPatrickGill commented Nov 28, 2023

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

This bumps the snyk-nodejs-lockfile-parser to 1.52.8. Details can be found here https://github.com/snyk/nodejs-lockfile-parser/releases

Automated Testing

https://github.com/snyk/nodejs-lockfile-parser/tree/master/test/jest/dep-graph-builders/fixtures/npm-lock-v2/override-with-dep

This was tested inside the plugin with this additional fixture

RISK ASSEMENT: HIGH

Has the chance to break things, unlikely though as no tests have failed in our plugin suite here https://github.com/snyk/nodejs-lockfile-parser/runs/19100237535

Where should the reviewer start?

This is a dependency bump please look at the release inside of the bumped package

How should this be manually tested?

One can run a test against the fixture here https://github.com/snyk/nodejs-lockfile-parser/tree/master/test/jest/dep-graph-builders/fixtures/npm-lock-v2/override-with-dep

Before this change, it would fail. After it will pass.

Any background context you want to provide?

This is the next step in supporting overrides for npm7

What are the relevant tickets?

Screenshots

Additional questions

@JamesPatrickGill JamesPatrickGill requested a review from a team as a code owner November 28, 2023 15:08
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed description! LGTM!

@JamesPatrickGill JamesPatrickGill requested a review from a team as a code owner November 28, 2023 16:01
@JamesPatrickGill JamesPatrickGill force-pushed the fix/bump-nodejs-parser-to-1.52.8 branch 2 times, most recently from 5479aeb to 842160f Compare November 28, 2023 16:08
@JamesPatrickGill JamesPatrickGill enabled auto-merge (squash) November 28, 2023 16:08
@bastiandoetsch bastiandoetsch merged commit dbc5b92 into master Nov 29, 2023
14 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/bump-nodejs-parser-to-1.52.8 branch November 29, 2023 07:21
orsagie pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants