Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update gradle plugin version #4955

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

anthogez
Copy link
Member

@anthogez anthogez commented Nov 30, 2023

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.

Risk

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Fix the following issue snyk/snyk-gradle-plugin#270

How should this be manually tested?

Try to scan the project mentioned in this issue

Screenshots

N/A

@anthogez anthogez requested a review from a team as a code owner November 30, 2023 12:03
@anthogez anthogez force-pushed the feat/update-gradle-plugin-version branch from e69f6e7 to 15a69b0 Compare November 30, 2023 12:04
@anthogez anthogez merged commit 2bdaf4c into master Nov 30, 2023
14 checks passed
@anthogez anthogez deleted the feat/update-gradle-plugin-version branch November 30, 2023 13:38
@anthogez anthogez self-assigned this Nov 30, 2023
@cookieMr
Copy link

cookieMr commented Nov 30, 2023

Thx you folks for such a fast fix!

Just to confirm, this fix will be available in release v1.1260.0?

orsagie pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants