-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [OSM-894] Add test support for .NET 8 #4963
Conversation
19cd50b
to
5b90fff
Compare
5b90fff
to
5cb2081
Compare
@@ -4,4 +4,5 @@ | |||
<package id="make" version="4.4.1" /> | |||
<package id="gradle" version="8.1.1" /> | |||
<package id="python3" version="3.11.4" /> | |||
<package id="dotnet-sdk" version="8.0.100" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default the windows executor uses the 7.0
SDK, so need to force an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI said they update them once every 6 months or something.
dc46aa8
to
50327da
Compare
Please sign all commits :) |
50327da
to
8cbde36
Compare
8cbde36
to
233ba0c
Compare
233ba0c
to
38a82a6
Compare
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Adds test capabilities to ensure that
snyk test --dotnet-runtime-resolution
works for .NET projects targeting version 8 (new LTS).Where should the reviewer start?
The circleci config files and Dockerfile.
How should this be manually tested?
/bin/snyk test --dotnet-runtime-resolution
with thedotnet
SDK version 8 installed on your machine.Any background context you want to provide?
All of the actual support is nested in the
snyk-nuget-plugin
, this just ensures that we can test .NET 8 projects in the acceptance tests.What are the relevant tickets?
https://snyksec.atlassian.net/browse/OSM-894
Risk
Low. It's already tested and working in the plugin: https://github.com/snyk/snyk-nuget-plugin/blob/ae06ef40098d9281aec2317fb9b50199d8c89f36/test/parsers/parse-core-v2.spec.ts#L39-L41