Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OSM-894] Add test support for .NET 8 #4963

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

dotkas
Copy link
Contributor

@dotkas dotkas commented Dec 11, 2023

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Adds test capabilities to ensure that snyk test --dotnet-runtime-resolution works for .NET projects targeting version 8 (new LTS).

Where should the reviewer start?

The circleci config files and Dockerfile.

How should this be manually tested?

/bin/snyk test --dotnet-runtime-resolution with the dotnet SDK version 8 installed on your machine.

Any background context you want to provide?

All of the actual support is nested in the snyk-nuget-plugin, this just ensures that we can test .NET 8 projects in the acceptance tests.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/OSM-894

Risk

Low. It's already tested and working in the plugin: https://github.com/snyk/snyk-nuget-plugin/blob/ae06ef40098d9281aec2317fb9b50199d8c89f36/test/parsers/parse-core-v2.spec.ts#L39-L41

@dotkas dotkas requested review from a team as code owners December 11, 2023 18:59
@@ -4,4 +4,5 @@
<package id="make" version="4.4.1" />
<package id="gradle" version="8.1.1" />
<package id="python3" version="3.11.4" />
<package id="dotnet-sdk" version="8.0.100" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the windows executor uses the 7.0 SDK, so need to force an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI said they update them once every 6 months or something.

@dotkas dotkas force-pushed the dotkas/OSM-894/dotnet-8-lts branch 2 times, most recently from dc46aa8 to 50327da Compare December 12, 2023 19:18
@dotkas dotkas enabled auto-merge (squash) December 12, 2023 20:09
@dotkas dotkas disabled auto-merge December 13, 2023 13:23
@bastiandoetsch
Copy link
Contributor

Please sign all commits :)

@dotkas dotkas enabled auto-merge (squash) December 13, 2023 13:26
@dotkas dotkas force-pushed the dotkas/OSM-894/dotnet-8-lts branch from 233ba0c to 38a82a6 Compare January 11, 2024 08:51
@dotkas dotkas requested a review from a team as a code owner January 11, 2024 08:51
@dotkas dotkas merged commit a4277ba into master Jan 12, 2024
14 checks passed
@dotkas dotkas deleted the dotkas/OSM-894/dotnet-8-lts branch January 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants