fix: fix the proxy tests, ensure that CONNECT method is used #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Validation of succeeding (needle 3.0.0) failing (needle 3.3.0) and succeeding (needle 3.3.0 with Validation of HTTP requests to proxy using needle 3.3.0 and |
3 tasks
neonnoon
force-pushed
the
fix/uprade-needle-test-proxy
branch
from
b2573e6
to
6dd2a90
Compare
PeterSchafer
approved these changes
Jan 5, 2024
Expect tests to fail / CONNECT will not be used until proxy is disabled in needle.
neonnoon
force-pushed
the
fix/uprade-needle-test-proxy
branch
from
667ae4c
to
cda1030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
@snyk/code-clientwith updated needle fix: upgrade needle and disable proxy in needle code-client#224@types/needleto support the new option introduced in [needle] feat: add support for needle's use_proxy_from_env_var DefinitelyTyped/DefinitelyTyped#67880Why
In #4953 we had to revert to an older version of needle.
We want to make sure we can continue to upgrade needle and we don't accidentally break proxy support on upgrades.